Skip to content

Commit 685d101

Browse files
authored
3.9.0 (#361)
* update, thread-safe mojo * resilience, javadoc warnings * outputs/docstrings does not yield different scenarios * 3.8.3 -> 3.9.0
1 parent 1c14bcb commit 685d101

41 files changed

Lines changed: 338 additions & 102 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

CHANGELOG.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,22 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
77

88
Back to [Readme](README.md).
99

10+
## [3.9.0] - 2024-11-05
11+
12+
### Fixed
13+
14+
* Plugin doesn't support parallel compilation (#358)
15+
* Merging of reports with same test scenario doesn't work when output is different (#359)
16+
* Dark mode flickering on navigation
17+
* Wrong dark mode toggle caption when starting with dark mode active
18+
* Fixed all Javadoc warnings
19+
20+
### Changed
21+
22+
* Shortened dark/light mode button caption
23+
* Allow report generation even if `<customParametersFile>` defined file does not exist (#357)
24+
* Updated JUnit Jupiter, Mockito, JavaDoc and GPG plugins
25+
1026
## [3.8.2] - 2024-10-30
1127

1228
### Added
@@ -924,6 +940,8 @@ the core component is now the reporting engine that is the base for other forms
924940

925941
Initial project version on GitHub and Maven Central.
926942

943+
[3.9.0]: https://github.com/trivago/cluecumber-report-plugin/tree/v3.9.0
944+
927945
[3.8.2]: https://github.com/trivago/cluecumber-report-plugin/tree/v3.8.2
928946

929947
[3.8.1]: https://github.com/trivago/cluecumber-report-plugin/tree/v3.8.1

core/src/main/java/com/trivago/cluecumber/core/CluecumberCore.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public class CluecumberCore {
3636
* @param builder The builder instance.
3737
* @throws CluecumberException Thrown in case of any error.
3838
*/
39-
private CluecumberCore(Builder builder) throws CluecumberException {
39+
private CluecumberCore(final Builder builder) throws CluecumberException {
4040
cluecumberEngine = DaggerCluecumberCoreGraph.create().getCluecumberEngine();
4141
cluecumberEngine.setCustomCssFile(builder.customCssFile);
4242
cluecumberEngine.setCustomFavicon(builder.customFavicon);
@@ -73,7 +73,7 @@ public void generateReports(final String jsonDirectory, final String reportDirec
7373
}
7474

7575
/**
76-
* The builder class for a new {@link CluecumberCore} instance.
76+
* The builder class for the {@link CluecumberCore}.
7777
*/
7878
public static class Builder {
7979
private String customCssFile;
@@ -98,6 +98,13 @@ public static class Builder {
9898
private boolean failScenariosOnPendingOrUndefinedSteps;
9999
private boolean expandOutputs;
100100

101+
/**
102+
* Default constructor for the Builder class.
103+
*/
104+
public Builder() {
105+
// Default constructor
106+
}
107+
101108
/**
102109
* Finalize the {@link CluecumberCore} builder.
103110
*
@@ -141,7 +148,6 @@ public Builder setCustomNavigationLinks(final LinkedHashMap<String, String> cust
141148
return this;
142149
}
143150

144-
145151
/**
146152
* Custom parameters to display at the top of the test report.
147153
*
@@ -153,7 +159,6 @@ public Builder setCustomParameters(final LinkedHashMap<String, String> customPar
153159
return this;
154160
}
155161

156-
157162
/**
158163
* Where to display custom parameters.
159164
*

engine/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
<properties>
3030
<maven.compiler.release>11</maven.compiler.release>
3131
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
32-
<maven-compiler-plugin.version>3.13.0</maven-compiler-plugin.version>
3332
<tinylog-impl.version>2.8.0-M1</tinylog-impl.version>
3433
<freemarker.version>2.3.33</freemarker.version>
3534
<gson-fire.version>1.9.0</gson-fire.version>
@@ -38,7 +37,6 @@
3837
<property-aggregator.version>1.5.0</property-aggregator.version>
3938
<properties-maven-plugin.version>1.1.0</properties-maven-plugin.version>
4039
<openpojo.version>0.9.1</openpojo.version>
41-
<maven-jar-plugin.version>3.4.2</maven-jar-plugin.version>
4240
</properties>
4341

4442
<dependencies>
@@ -95,7 +93,6 @@
9593
<plugin>
9694
<groupId>org.apache.maven.plugins</groupId>
9795
<artifactId>maven-compiler-plugin</artifactId>
98-
<version>${maven-compiler-plugin.version}</version>
9996
<configuration>
10097
<annotationProcessorPaths>
10198
<path>
@@ -112,7 +109,6 @@
112109
<plugin>
113110
<groupId>org.apache.maven.plugins</groupId>
114111
<artifactId>maven-jar-plugin</artifactId>
115-
<version>${maven-jar-plugin.version}</version>
116112
<configuration>
117113
<archive>
118114
<manifest>

engine/src/main/java/com/trivago/cluecumber/engine/CluecumberEngine.java

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,11 @@ public void setCustomParameters(final LinkedHashMap<String, String> customParame
166166
* @throws CluecumberException Thrown on any error.
167167
*/
168168
public void setCustomParametersFile(final String customParametersFile) throws CluecumberException {
169-
propertyManager.setCustomParametersFile(customParametersFile);
169+
try {
170+
propertyManager.setCustomParametersFile(customParametersFile);
171+
} catch (MissingFileException e) {
172+
logger.warn("Could not read custom parameters file: " + e.getMessage());
173+
}
170174
}
171175

172176
/**
@@ -284,6 +288,12 @@ public void setCustomCssFile(final String customCss) throws MissingFileException
284288
propertyManager.setCustomCssFile(customCss);
285289
}
286290

291+
/**
292+
* Custom favicon file to use for the report.
293+
*
294+
* @param customFavicon The path to a favicon file.
295+
* @throws MissingFileException Thrown if the specified file does not exist.
296+
*/
287297
public void setCustomFavicon(final String customFavicon) throws MissingFileException {
288298
if (customFavicon == null) {
289299
return;

engine/src/main/java/com/trivago/cluecumber/engine/constants/Navigation.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,13 @@
2525
* Report navigation.
2626
*/
2727
public class Navigation {
28+
/**
29+
* Default constructor.
30+
*/
31+
public Navigation() {
32+
// Default constructor
33+
}
34+
2835
/**
2936
* The list of internal report navigation links.
3037
*/

engine/src/main/java/com/trivago/cluecumber/engine/constants/Settings.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,13 @@
2020
*/
2121
public class Settings {
2222

23+
/**
24+
* Default constructor.
25+
*/
26+
public Settings() {
27+
// Default constructor
28+
}
29+
2330
/**
2431
* The name of the Cluecumber plugin.
2532
*/

engine/src/main/java/com/trivago/cluecumber/engine/json/pojo/Argument.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,13 @@ public class Argument {
2222
private String val;
2323
private int offset;
2424

25+
/**
26+
* Default constructor.
27+
*/
28+
public Argument() {
29+
// Default constructor
30+
}
31+
2532
/**
2633
* Gets the value of the argument.
2734
*

engine/src/main/java/com/trivago/cluecumber/engine/json/pojo/DocString.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,13 @@ public class DocString {
2424
private int line;
2525
private String value = "";
2626

27+
/**
28+
* Default constructor.
29+
*/
30+
public DocString() {
31+
// Default constructor
32+
}
33+
2734
/**
2835
* Get the line number.
2936
*

engine/src/main/java/com/trivago/cluecumber/engine/json/pojo/Element.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,13 @@ public class Element {
5252
private transient int scenarioIndex = 0;
5353
private transient boolean failOnPendingOrUndefined = false;
5454

55+
/**
56+
* Default constructor.
57+
*/
58+
public Element() {
59+
// Default constructor
60+
}
61+
5562
/**
5663
* Get the list of tags of this scenario.
5764
*

engine/src/main/java/com/trivago/cluecumber/engine/json/pojo/Embedding.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,13 @@ public class Embedding {
3636

3737
private transient String filename = "";
3838

39+
/**
40+
* Default constructor.
41+
*/
42+
public Embedding() {
43+
// Default constructor
44+
}
45+
3946
/**
4047
* Get the raw attachment data.
4148
*

0 commit comments

Comments
 (0)