Skip to content

Conversation

@svchb
Copy link
Collaborator

@svchb svchb commented Sep 4, 2025

In my quick testing this didn't show the claimed accuracy improvement vs Wendland and Quintic.

@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 57.14286% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.88%. Comparing base (d193c71) to head (f800e03).
⚠️ Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
src/general/smoothing_kernels.jl 57.14% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #893      +/-   ##
==========================================
- Coverage   65.94%   65.88%   -0.06%     
==========================================
  Files         113      113              
  Lines        7852     7880      +28     
==========================================
+ Hits         5178     5192      +14     
- Misses       2674     2688      +14     
Flag Coverage Δ
unit 65.88% <57.14%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svchb svchb self-assigned this Sep 4, 2025
@svchb svchb added the enhancement New feature or request label Sep 4, 2025
@svchb
Copy link
Collaborator Author

svchb commented Sep 4, 2025

The normal smoothing kernel test that we have doesn't work here since the truncation error is too large.

@efaulhaber
Copy link
Member

The normal smoothing kernel test that we have doesn't work here since the truncation error is too large.

The Gauss kernel is also truncated. Why can't you run the same tests for this kernel?

@efaulhaber efaulhaber closed this Sep 26, 2025
@efaulhaber efaulhaber reopened this Sep 26, 2025
@svchb
Copy link
Collaborator Author

svchb commented Sep 26, 2025

The normal smoothing kernel test that we have doesn't work here since the truncation error is too large.

The Gauss kernel is also truncated. Why can't you run the same tests for this kernel?

I can but the errors seem to be unreasonable because they are larger than 1.

@svchb svchb requested a review from efaulhaber September 29, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants