feat(ecmascript): SharedArrayBuffer backed TypedArrays and DataViews (#869)

Author: aapoalas

Cargo.toml

@@ -20,6 +20,7 @@ clap = { version = "4.5.48", features = ["derive"] }
 cliclack = "0.3.6"
 console = "0.15.11"
 ctrlc = "3.5.0"
+ecmascript_atomics = "0.1.4"
 fast-float = "0.2.0"
 hashbrown = "0.16.0"
 lexical = { version = "7.0.5", default-features = false, features = [
@@ -43,9 +44,9 @@ oxc_syntax = "0.94.0"
 rand = "0.9.2"
 regex = "1.11.3"
 ryu-js = "1.0.2"
-sonic-rs = "0.3.17"
 soavec = "0.1.1"
 soavec_derive = "0.1.1"
+sonic-rs = "0.3.17"
 unicode-normalization = "0.1.24"
 usdt = { git = "https://github.com/aapoalas/usdt.git", branch = "nova-aarch64-branch" }
 wtf8 = "0.1"

nova_vm/Cargo.toml

@@ -13,6 +13,7 @@ categories.workspace = true
 
 [dependencies]
 ahash = { workspace = true }
+ecmascript_atomics = { workspace = true }
 fast-float = { workspace = true }
 hashbrown = { workspace = true }
 lexical = { workspace = true }
@@ -31,9 +32,9 @@ rand = { workspace = true }
 regex = { workspace = true }
 ryu-js = { workspace = true }
 small_string = { path = "../small_string", version = "0.2.0" }
-sonic-rs = { workspace = true, optional = true }
 soavec = { workspace = true }
 soavec_derive = { workspace = true }
+sonic-rs = { workspace = true, optional = true }
 unicode-normalization = { workspace = true }
 usdt = { workspace = true }
 wtf8 = { workspace = true }

nova_vm/src/ecmascript/abstract_operations/operations_on_objects.rs

@@ -1374,9 +1374,8 @@ pub(crate) fn species_constructor<'a>(
     }
     // 3. If C is not an Object, throw a TypeError exception.
     let Ok(c) = Object::try_from(c) else {
-        return Err(agent.throw_exception_with_static_message(
-            ExceptionType::TypeError,
-            "constructor property value is not an object",
+        return Err(throw_constructor_property_not_an_object(
+            agent,
             gc.into_nogc(),
         ));
     };
@@ -1401,13 +1400,89 @@ pub(crate) fn species_constructor<'a>(
         return Ok(s.unbind());
     }
     // 7. Throw a TypeError exception.
-    Err(agent.throw_exception_with_static_message(
-        ExceptionType::TypeError,
-        "constructor species is not a constructor",
+    Err(throw_species_constructor_is_not_a_constructor(
+        agent,
         gc.into_nogc(),
     ))
 }
 
+#[cold]
+#[inline(never)]
+fn throw_constructor_property_not_an_object<'gc>(
+    agent: &mut Agent,
+    gc: NoGcScope<'gc, '_>,
+) -> JsError<'gc> {
+    agent.throw_exception_with_static_message(
+        ExceptionType::TypeError,
+        "constructor property value is not an object",
+        gc.into_nogc(),
+    )
+}
+
+#[cold]
+#[inline(never)]
+fn throw_species_constructor_is_not_a_constructor<'gc>(
+    agent: &mut Agent,
+    gc: NoGcScope<'gc, '_>,
+) -> JsError<'gc> {
+    agent.throw_exception_with_static_message(
+        ExceptionType::TypeError,
+        "species constructor is not a constructor",
+        gc.into_nogc(),
+    )
+}
+
+/// ### [7.3.22 SpeciesConstructor ( O, defaultConstructor )](https://tc39.es/ecma262/multipage/abstract-operations.html#sec-speciesconstructor)
+pub(crate) fn try_species_constructor<'gc>(
+    agent: &mut Agent,
+    o: Object<'gc>,
+    default_constructor: ProtoIntrinsics,
+    gc: NoGcScope<'gc, '_>,
+) -> TryResult<'gc, Option<Function<'gc>>> {
+    // 1. Let C be ? Get(O, "constructor").
+    let c = try_get_result_into_value(try_get(
+        agent,
+        o,
+        BUILTIN_STRING_MEMORY.constructor.into(),
+        None,
+        gc,
+    ))?;
+    // 2. If C is undefined, return defaultConstructor.
+    if c.is_undefined() {
+        return TryResult::Continue(None);
+    }
+    // 3. If C is not an Object, throw a TypeError exception.
+    let Ok(c) = Object::try_from(c) else {
+        return throw_constructor_property_not_an_object(agent, gc).into();
+    };
+    // 4. Let S be ? Get(C, %Symbol.species%).
+    let s = try_get_result_into_value(try_get(
+        agent,
+        c,
+        WellKnownSymbolIndexes::Species.into(),
+        None,
+        gc,
+    ))?;
+    // 5. If S is either undefined or null, return defaultConstructor.
+    if s.is_undefined() || s.is_null() {
+        return TryResult::Continue(None);
+    }
+    // 6. If IsConstructor(S) is true, return S.
+    if let Some(s) = is_constructor(agent, s) {
+        let default_constructor = agent
+            .current_realm_record()
+            .intrinsics()
+            .get_intrinsic_default_constructor(default_constructor);
+        return TryResult::Continue(if s == default_constructor {
+            None
+        } else {
+            Some(s)
+        });
+    }
+    // 7. Throw a TypeError exception.
+    throw_species_constructor_is_not_a_constructor(agent, gc).into()
+}
+
 pub(crate) fn is_prototype_of_loop<'a>(
     agent: &mut Agent,
     o: Object,

nova_vm/src/ecmascript/abstract_operations/type_conversion.rs

@@ -409,9 +409,28 @@ pub(crate) fn string_to_number<'gc>(
 ///
 /// If the JavaScript number was infinite, then the appropriate i64 minimum or
 /// maximum value is used as a sentinel.
-#[derive(Debug, Clone, Copy, PartialEq, PartialOrd)]
+#[derive(Clone, Copy, PartialEq, PartialOrd)]
 pub(crate) struct IntegerOrInfinity(i64);
 
+impl core::fmt::Display for IntegerOrInfinity {
+    fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
+        if self.is_finite() {
+            self.0.fmt(f)
+        } else if self.is_neg_infinity() {
+            f.write_str("-Infinity")
+        } else {
+            f.write_str("Infinity")
+        }
+    }
+}
+
+impl core::fmt::Debug for IntegerOrInfinity {
+    #[inline(always)]
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        <Self as core::fmt::Display>::fmt(self, f)
+    }
+}
+
 impl IntegerOrInfinity {
     pub(crate) const NEG_INFINITY: Self = Self(i64::MIN);
     pub(crate) const POS_INFINITY: Self = Self(i64::MAX);
@@ -596,7 +615,7 @@ pub(crate) fn to_int32<'a>(
 /// ### [7.1.6 ToInt32 ( argument )](https://tc39.es/ecma262/#sec-toint32)
 ///
 /// Implements steps 2 to 5 of the abstract operation, callable only with Numbers.
-pub(crate) fn to_int32_number(agent: &mut Agent, number: Number) -> i32 {
+pub(crate) fn to_int32_number(agent: &Agent, number: Number) -> i32 {
     if let Number::Integer(int) = number {
         let int = int.into_i64();
         return int as i32;
@@ -635,7 +654,7 @@ pub(crate) fn to_uint32<'a>(
 /// ### [7.1.7 ToUint32 ( argument )](https://tc39.es/ecma262/#sec-touint32)
 ///
 /// Implements steps 2 to 5 of the abstract operation, callable only with Numbers.
-pub(crate) fn to_uint32_number(agent: &mut Agent, number: Number) -> u32 {
+pub(crate) fn to_uint32_number(agent: &Agent, number: Number) -> u32 {
     if let Number::Integer(int) = number {
         let int = int.into_i64();
         return int as u32;
@@ -670,7 +689,7 @@ pub(crate) fn to_int16<'a>(
     Ok(to_int16_number(agent, number))
 }
 
-pub(crate) fn to_int16_number(agent: &mut Agent, number: Number) -> i16 {
+pub(crate) fn to_int16_number(agent: &Agent, number: Number) -> i16 {
     if let Number::Integer(int) = number {
         // Fast path: Integer value is very nearly int16 already.
         let int = int.into_i64();
@@ -706,7 +725,7 @@ pub(crate) fn to_uint16<'a>(
     Ok(to_uint16_number(agent, number))
 }
 
-pub(crate) fn to_uint16_number(agent: &mut Agent, number: Number) -> u16 {
+pub(crate) fn to_uint16_number(agent: &Agent, number: Number) -> u16 {
     if let Number::Integer(int) = number {
         // Fast path: Integer value is very nearly uin16 already.
         let int = int.into_i64();
@@ -742,7 +761,7 @@ pub(crate) fn to_int8<'a>(
     Ok(to_int8_number(agent, number))
 }
 
-pub(crate) fn to_int8_number(agent: &mut Agent, number: Number) -> i8 {
+pub(crate) fn to_int8_number(agent: &Agent, number: Number) -> i8 {
     if let Number::Integer(int) = number {
         // Fast path: Integer value is very nearly uint32 already.
         let int = int.into_i64();
@@ -778,7 +797,7 @@ pub(crate) fn to_uint8<'a>(
     Ok(to_uint8_number(agent, number))
 }
 
-pub(crate) fn to_uint8_number(agent: &mut Agent, number: Number) -> u8 {
+pub(crate) fn to_uint8_number(agent: &Agent, number: Number) -> u8 {
     if let Number::Integer(int) = number {
         // Fast path: Integer value is very nearly uint32 already.
         let int = int.into_i64();
@@ -814,7 +833,7 @@ pub(crate) fn to_uint8_clamp<'a>(
     Ok(to_uint8_clamp_number(agent, number))
 }
 
-pub(crate) fn to_uint8_clamp_number(agent: &mut Agent, number: Number) -> u8 {
+pub(crate) fn to_uint8_clamp_number(agent: &Agent, number: Number) -> u8 {
     if let Number::Integer(int) = number {
         // Fast path: Integer value is very nearly uint8 already.
         return int.into_i64().clamp(0, 255) as u8;
@@ -969,7 +988,7 @@ pub(crate) fn to_big_int64<'a>(
     Ok(to_big_int64_big_int(agent, n))
 }
 
-pub(crate) fn to_big_int64_big_int(agent: &mut Agent, n: BigInt) -> i64 {
+pub(crate) fn to_big_int64_big_int(agent: &Agent, n: BigInt) -> i64 {
     // 2. Let int64bit be ℝ(n) modulo 2**64.
     match n {
         BigInt::BigInt(heap_big_int) => {
@@ -1003,7 +1022,7 @@ pub(crate) fn to_big_uint64<'a>(
     Ok(to_big_uint64_big_int(agent, n))
 }
 
-pub(crate) fn to_big_uint64_big_int(agent: &mut Agent, n: BigInt) -> u64 {
+pub(crate) fn to_big_uint64_big_int(agent: &Agent, n: BigInt) -> u64 {
     // 2. Let int64bit be ℝ(n) modulo 2**64.
     match n {
         BigInt::BigInt(heap_big_int) => {

nova_vm/src/ecmascript/builtins/array.rs

@@ -54,7 +54,7 @@ use super::ordinary::{
     ordinary_has_property, ordinary_try_get, ordinary_try_has_property,
 };
 
-#[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Hash)]
 #[repr(transparent)]
 pub struct Array<'a>(BaseIndex<'a, ArrayHeapData<'static>>);