EIWFY23Q4-1 Sort validation by line by default

Author: slatlasdev

src/LoadSchema.tsx

@@ -77,7 +77,7 @@ class LoadSchemaWR extends React.PureComponent<LoadSchemaProps, LoadSchemaState>
                header="Schema load failed"
                description="Attempted to pull the JSON Schema down from the public internet."
                primaryAction={(
-                  <p>Error: ${result.schema.message}</p>
+                  <p>Error: {result.schema.message}</p>
                )}
             />
          );
@@ -96,4 +96,4 @@ class LoadSchemaWR extends React.PureComponent<LoadSchemaProps, LoadSchemaState>
    }
 }
 
-export const LoadSchema = withRouter<LoadSchemaProps, typeof LoadSchemaWR>(LoadSchemaWR);
+export const LoadSchema = withRouter<LoadSchemaProps, typeof LoadSchemaWR>(LoadSchemaWR);

src/SchemaValidator.tsx

@@ -37,26 +37,32 @@ const severityDefinitions = {
 };
 
 export const SchemaValidator: FC<SchemaValidatorProps> = ({ results, onSelectRange }) => {
+  const sortedByLineNumber = results.sort((a, b) => {
+    if (a.startLineNumber !== b.startLineNumber) {
+      return a.startLineNumber - b.startLineNumber;
+    }
+    return a.startColumn - b.startColumn;
+  });
   return (
     <Table>
       <THead>
         <SortableColumn name="severity">Severity</SortableColumn>
         <SortableColumn name="message">Message</SortableColumn>
         <SortableColumn name="startLineNumber">Location</SortableColumn>
       </THead>
-      <TBody rows={results}>
+      <TBody rows={sortedByLineNumber}>
         {(row) => {
           const { label, icon: Icon, color } = severityDefinitions[row.severity];
           const {
-            modelVersionId,
             message,
             startColumn,
             startLineNumber,
             endColumn,
             endLineNumber,
           } = row;
+          const locationString = `${startLineNumber}:${startColumn}-${endLineNumber}:${endColumn}`
           return (
-            <Row key={modelVersionId}>
+            <Row key={`${locationString}-${message}`}>
               <Cell>
                 <Flex>
                   <Icon label={label} primaryColor={color} />
@@ -77,7 +83,7 @@ export const SchemaValidator: FC<SchemaValidatorProps> = ({ results, onSelectRan
                     });
                   }}
                 >
-                  {startLineNumber}:{startColumn}-{endLineNumber}:{endColumn}
+                  {locationString}
                 </a>
               </Cell>
             </Row>