Skip to content

Commit d347cfa

Browse files
authored
Merge pull request #4320 from armanbilge/issue/4244
Fix ambiguous `contains_` syntax
2 parents d936d43 + 9857c1e commit d347cfa

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

core/src/main/scala/cats/syntax/foldable.scala

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,11 @@ trait FoldableSyntax extends Foldable.ToFoldableOps with UnorderedFoldable.ToUno
2727
implicit final def catsSyntaxNestedFoldable[F[_]: Foldable, G[_], A](fga: F[G[A]]): NestedFoldableOps[F, G, A] =
2828
new NestedFoldableOps[F, G, A](fga)
2929

30-
implicit final def catsSyntaxFoldOps[F[_]: Foldable, A](fa: F[A]): FoldableOps[F, A] =
30+
implicit final def catsSyntaxFoldOps[F[_], A](fa: F[A]): FoldableOps[F, A] =
31+
new FoldableOps[F, A](fa)
32+
33+
@deprecated("Use overload without Foldable parameter", "2.9.0")
34+
final def catsSyntaxFoldOps[F[_], A](fa: F[A], F: Foldable[F]): FoldableOps[F, A] =
3135
new FoldableOps[F, A](fa)
3236
}
3337

tests/shared/src/test/scala-2.13+/cats/tests/ScalaVersionSpecific.scala

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,10 @@ trait ScalaVersionSpecificFoldableSuite { self: FoldableSuiteAdditional =>
121121
assert((1 #:: boomLazyList[Int]).findM[Id](_ > 0) == Some(1))
122122
assert((1 #:: boomLazyList[Int]).collectFirstSomeM[Id, Int](Option.apply) == Some(1))
123123
}
124+
125+
test("#4244 ambiguous `contains_` syntax") {
126+
assertEquals(List("a").map(List("a").contains_), List(true))
127+
}
124128
}
125129

126130
trait ScalaVersionSpecificParallelSuite { self: ParallelSuite =>

0 commit comments

Comments
 (0)