-
Notifications
You must be signed in to change notification settings - Fork 760
progressive-layout:1.0.0 #3361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
progressive-layout:1.0.0 #3361
Conversation
… package submission
elegaanz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small suggestions to improve your README.
| #import "@preview/progressive-layout:1.0.0": progressive-layout, progressive-outline | ||
|
|
||
| // Apply the template to your document | ||
| #show: doc => progressive-layout(doc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is more idiomatic to write #show doc: progressive-layout, can you please update the example here (and other example files, using .with(...) in case you need to supply other arguments)?
| This package includes two files to demonstrate its usage: | ||
|
|
||
| - [`example.typ`](https://github.com/eusebe/progressive-layout/blob/main/example.typ): This file shows how the `progressive-outline` function works with different options. | ||
| - [`demo.typ`](https://github.com/eusebe/progressive-layout/blob/main/demo.typ): This file provides an example of how to use the `progressive-layout` template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would either:
- link to the files in this repository (i.e.
[\example.typ`](example.typ)`) - delete the copy of the files in this repository, and link to a pinned commit or tag in your own repository (by replacing
mainin the URL with the commit hash or tag name)
This was, you can be sure that the example files will always be in sync with the version of the package the user is reading the README for. Currently, if you push a breaking API change, the examples won't work anymore for people still reading the old README.
I am submitting
Description: This package provides a Typst function,
progressive-outline, and a tempate,progressive-layout, to generate a dynamic table of contents, similar to what is found in some LaTeX's Beamer presentations.I have read and followed the submission guidelines and, in particular, I
[X ] selected a name that isn't the most obvious or canonical name for what the package does
[ X] added a
typst.tomlfile with all required keys[ X] added a
README.mdwith documentation for my package[ X] have chosen a license and added a
LICENSEfile or linked one in myREADME.md[ X] tested my package locally on my system and it worked
[ X]
excluded PDFs or README images, if any, but not the LICENSE[ X] ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.