Skip to content

Commit 997990f

Browse files
committed
Fix fallback input for release action for real
Turns out `'master'` probably worked all along as a fallback, the problem is that I was using `'master '`, with a trailing space, which was not a branch git managed to find for obvious reason, and since I carried the error into the fully qualified reference... is still didn't work. And manual triggers didn't have the issue because the tag was `required`, so I'd have to input the tag by hand every time, and the fallback value would be bypassed. - fix the fallback value - remove the requirement on `tag`, such that it's possible to manually trigger the action in a default state
1 parent 60b35ec commit 997990f

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

.github/workflows/release-builtins.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ on:
1111
tag:
1212
description: "uap-core ref to release"
1313
type: string
14-
required: true
1514
environment:
1615
description: "environment to release for (testpypy or pypy)"
1716
type: environment
@@ -30,7 +29,7 @@ jobs:
3029
persist-credentials: false
3130
- name: update core
3231
env:
33-
TAG: ${{ inputs.tag || 'origin/master '}}
32+
TAG: ${{ inputs.tag || 'origin/master' }}
3433
# needs to detach because we can update to a tag
3534
run: git -C uap-core switch --detach "$TAG"
3635
- name: Set up Python

0 commit comments

Comments
 (0)