Method interpolation in regexes

[choroba]

Perl doesn't interpolate method calls in double quoted strings and regexes, so the following lines don't do what their authors hoped for:

$ grep -E '=~ /[^/]+->[^/]+/' -r lib
lib/Treex/Block/Misc/CreateWordToSentenceIndex.pm:    my @nodes = grep { $_->tag =~ /$self->tag_regex/ } $zone->get_atree()->get_descendants();
lib/Treex/Block/T2TAMR/ApplyRules.pm:                                                if ( $rule_node_parent->t_lemma =~ /{$target_tree_node->wild->{'query_label'}->{$query}}[0]/i ) {

[martinpopel]

Block/Misc/CreateWordToSentenceIndex.pm was written by @ptakopysk, but I guess he does not care about this code anymore (nor anyone else), so perhaps it could be just deleted (so that no one reuses the anti-pattern).

Block/T2TAMR/ApplyRules.pm was written by @tuetschek and again I think he does not care about this code anymore. Maybe @dan-zeman could know if anyone still uses this code.

BTW: I don't plan to use nor maintain Treex anymore. So I will be happy to hand over the maintenance to someone, perhaps you, @choroba, or @dan-zeman (actually, this is the status quo, as both of you are members of @ufal/ex-owners and thus admins of this repo). That said, I am happy it is still being used.

[ptakopysk]

I agree with Martin, I don't even understand this code of mine anymore, nor know what it was used for or how to fix it. But thanks for spotting that, if you are using it then feel free to fix it if you know how!

[choroba]

@ptakopysk Yours is easy to fix (one can just remove the slashes). The second one is tougher, though, as it's not clear what the author wanted it to do.

[tuetschek]

I unfortunately also have no idea what my code does. The whole T2AMR thing was written in a rush at JSALT 2014, wasn't very successful and I'm not aware that it's been used ever since.

But I suppose you could also just remove the slashes? You probably want to check if the t-lemma matches whatever is stored in that weird structure. (Sorry if it doesn't make sense, I haven't used Perl in about 8 years and don't remember much of the syntax :-(. )

[choroba]

@tuetschek: Unfortunately, the thing without slashes makes no sense (and the /i would be gone). {...}[0] is a syntax error.