fix: Remove alarm sound

Author: uncomputable

src/components/program_window/program_tab.rs

@@ -3,8 +3,8 @@ use std::sync::Arc;
 use itertools::Itertools;
 use leptos::{
     component, create_node_ref, create_rw_signal, ev, event_target_value, html, spawn_local,
-    use_context, view, IntoView, NodeRef, RwSignal, Signal, SignalGetUntracked, SignalSet,
-    SignalUpdate, SignalWith, SignalWithUntracked,
+    use_context, view, IntoView, RwSignal, Signal, SignalGetUntracked, SignalSet, SignalUpdate,
+    SignalWith, SignalWithUntracked,
 };
 use simfony::parse::ParseFromStr;
 use simfony::simplicity::jet::elements::ElementsEnv;
@@ -102,8 +102,6 @@ pub struct Runtime {
     pub run_succeeded: RwSignal<Option<bool>>,
     pub debug_output: RwSignal<String>,
     pub error_output: RwSignal<String>,
-    // This node ref needs to be mounted somewhere in order to work.
-    pub alarm_audio_ref: NodeRef<html::Audio>,
 }
 
 impl Runtime {
@@ -114,14 +112,10 @@ impl Runtime {
             run_succeeded: Default::default(),
             debug_output: Default::default(),
             error_output: Default::default(),
-            alarm_audio_ref: Default::default(),
         }
     }
 
     fn set_success(self, success: bool) {
-        if !success {
-            self.alarm_audio_ref.get().map(|audio| audio.play());
-        }
         spawn_local(async move {
             self.run_succeeded.set(Some(success));
             gloo_timers::future::TimeoutFuture::new(500).await;

src/components/program_window/run_button.rs

@@ -7,7 +7,6 @@ use crate::components::state::update_local_storage;
 pub fn RunButton() -> impl IntoView {
     let program = use_context::<Program>().expect("program should exist in context");
     let runtime = use_context::<Runtime>().expect("runtime should exist in context");
-    let audio_ref = runtime.alarm_audio_ref;
 
     let run_program = move |_event: ev::MouseEvent| {
         program.add_default_modules();
@@ -28,11 +27,5 @@ pub fn RunButton() -> impl IntoView {
             <i class="fas fa-play"></i>
             " Run"
         </button>
-        <audio
-            preload="auto"
-            node_ref=audio_ref
-        >
-          <source src="images/alarm.ogg" type="audio/ogg" />
-        </audio>
     }
 }