update middleware behavior

Author: notunderctrl

apps/test-bot/src/app/commands/(developer)/+middleware.ts

@@ -1,4 +1,4 @@
-import { Logger, MiddlewareContext } from 'commandkit';
+import { Logger, MiddlewareContext, stopMiddlewares } from 'commandkit';
 import { MessageFlags } from 'discord.js';
 
 export function beforeExecute(ctx: MiddlewareContext) {
@@ -16,7 +16,7 @@ export function beforeExecute(ctx: MiddlewareContext) {
       ctx.message.reply('You are not allowed to use this command.');
     }
 
-    ctx.cancel();
+    stopMiddlewares();
   }
 }
 

apps/test-bot/src/app/commands/(general)/+middleware.ts

@@ -1,9 +1,10 @@
-import { Logger, MiddlewareContext } from 'commandkit';
+import { Logger, MiddlewareContext, stopMiddlewares } from 'commandkit';
 
 export function beforeExecute(ctx: MiddlewareContext) {
   Logger.info(
     `Directory-scoped middleware: ${ctx.commandName} will be executed!`,
   );
+  // stopMiddlewares();
 }
 
 export function afterExecute(ctx: MiddlewareContext) {

apps/test-bot/src/app/commands/(general)/+ping.middleware.ts

@@ -1,9 +1,11 @@
-import { Logger, MiddlewareContext } from 'commandkit';
+import { Logger, type MiddlewareContext, stopMiddlewares } from 'commandkit';
 
 export function beforeExecute(ctx: MiddlewareContext) {
+  Logger.info(`Command-scoped middleware: ${ctx.commandName} will be stopped!`);
   Logger.info(
-    `Command-scoped middleware: ${ctx.commandName} will be executed!`,
+    'None of the other beforeExecute middlewares are supposed to be executed',
   );
+  // stopMiddlewares();
 }
 
 export function afterExecute(ctx: MiddlewareContext) {

apps/test-bot/src/app/commands/(general)/ping.ts

@@ -11,6 +11,7 @@ import {
   AutocompleteCommandContext,
   CommandMetadata,
   MessageCommandContext,
+  stopMiddlewares,
 } from 'commandkit';
 
 export const command: CommandData = {
@@ -33,8 +34,8 @@ export const command: CommandData = {
 };
 
 export const metadata: CommandMetadata = {
-  userPermissions: 'Administrator',
-  botPermissions: 'KickMembers',
+  // userPermissions: 'Administrator',
+  // botPermissions: 'KickMembers',
   // guilds: ['1314834483660455938'],
 };
 
@@ -98,4 +99,6 @@ export async function chatInput({
       button.setDisabled(true);
       message.edit({ components: [row] });
     });
+
+  stopMiddlewares();
 }

apps/test-bot/src/app/commands/(interactions)/+middleware.ts

@@ -1,4 +1,4 @@
-import { Logger, MiddlewareContext } from 'commandkit';
+import { Logger, MiddlewareContext, stopMiddlewares } from 'commandkit';
 import { MessageFlags } from 'discord.js';
 
 export function beforeExecute(ctx: MiddlewareContext) {
@@ -18,7 +18,7 @@ export function beforeExecute(ctx: MiddlewareContext) {
       ctx.message.reply('You are not allowed to use this command.');
     }
 
-    ctx.cancel();
+    stopMiddlewares();
   }
 }
 

apps/test-bot/src/app/commands/+global-middleware.ts

@@ -1,7 +1,9 @@
-import { Logger, MiddlewareContext } from 'commandkit';
+import { Logger, MiddlewareContext, stopMiddlewares } from 'commandkit';
 
 export function beforeExecute(ctx: MiddlewareContext) {
   Logger.info(`Global middleware: ${ctx.commandName} will be executed!`);
+  // ctx.message.reply('Global middleware: This command will not be executed!');
+  // stopMiddlewares();
 }
 
 export function afterExecute(ctx: MiddlewareContext) {

apps/test-bot/src/app/events/ready/logger.ts renamed to apps/test-bot/src/app/events/clientReady/logger.ts

@@ -2,7 +2,7 @@ import { type EventHandler, Logger } from 'commandkit';
 
 export const once = true;
 
-const handler: EventHandler<'ready'> = (client, c, commandkit) => {
+const handler: EventHandler<'clientReady'> = (client, c, commandkit) => {
   Logger.log(`Ready from legacy event handler: ${client.user.username}`);
 };
 

apps/test-bot/src/events/ready/test.ts

@@ -37,7 +37,7 @@ that looks something like this:
 │   │   ├── commands/
 │   │   │   └── ping.ts
 │   │   └── events/
-│   │       └── ready/
+│   │       └── clientReady/
 │   │           └── log.ts
 │   └── app.ts
 ├── .env

apps/website/docs/guide/01-getting-started/02-setup-commandkit.mdx

@@ -31,7 +31,7 @@ plugins, or even other commands through your `commandkit` instance.
 │   │   │       ├── kick.ts
 │   │   │       └── ban.ts
 │   │   └── events/
-│   │       └── ready/
+│   │       └── clientReady/
 │   │           └── log.ts
 │   └── app.ts
 ├── .env