Update test randomness and screenshots

Author: hojberg

tests/e2e/NewOrgModal.spec.ts

@@ -14,7 +14,7 @@ test.describe("without being signed in", () => {
   test("can *NOT* see the 'New Org' button", async ({ page, isMobile }) => {
     const response = await page.goto("http://localhost:1234");
     expect(response?.status()).toBeLessThan(400);
-    await expect(page).toHaveScreenshot("no-new-org-button.png");
+    await expect(page).toHaveScreenshot("no-new-org-button.png", { maxDiffPixels: 100 });
 
     if (isMobile) {
       await expect(
@@ -36,7 +36,7 @@ test.describe("while being signed in", () => {
   test("can see the 'New Org' button", async ({ page, isMobile }) => {
     const response = await page.goto("http://localhost:1234");
     expect(response?.status()).toBeLessThan(400);
-    await expect(page).toHaveScreenshot("new-org-button.png");
+    await expect(page).toHaveScreenshot("new-org-button.png", { maxDiffPixels: 100 });
 
     if (isMobile) {
       await expect(

tests/e2e/NewOrgModal.spec.ts-snapshots/new-org-button-Mobile-Chrome-darwin.png

@@ -1,5 +1,8 @@
 import { faker } from "@faker-js/faker";
 
+// Ensures test data is the same between runs (especially useful for screenshot comparisons)
+faker.seed(42);
+
 function account(handle: string) {
   return {
     ...user(),
@@ -21,7 +24,7 @@ function user(handle?: string) {
   const handle_ = handle ? handle : userHandle();
 
   return {
-    avatarUrl: faker.image.avatar(),
+    avatarUrl: faker.image.personPortrait(),
     handle: handle_.replace("@", ""),
     name: `${firstName} ${lastName}`,
     userId: faker.string.uuid(),
@@ -207,28 +210,28 @@ type DiffErrorCulprit = "new" | "old";
 type DiffErrorDetails =
   | { tag: "impossibleError" }
   | {
-      tag: "constructorAlias";
-      oldOrNewBranch: DiffErrorCulprit;
-      typeName: string;
-      constructorName1: string;
-      constructorName2: string;
-    }
+    tag: "constructorAlias";
+    oldOrNewBranch: DiffErrorCulprit;
+    typeName: string;
+    constructorName1: string;
+    constructorName2: string;
+  }
   | {
-      tag: "missingConstructorName";
-      oldOrNewBranch: DiffErrorCulprit;
-      typeName: string;
-    }
+    tag: "missingConstructorName";
+    oldOrNewBranch: DiffErrorCulprit;
+    typeName: string;
+  }
   | {
-      tag: "nestedDeclAlias";
-      oldOrNewBranch: DiffErrorCulprit;
-      constructorName1: string;
-      constructorName2: string;
-    }
+    tag: "nestedDeclAlias";
+    oldOrNewBranch: DiffErrorCulprit;
+    constructorName1: string;
+    constructorName2: string;
+  }
   | {
-      tag: "strayConstructor";
-      oldOrNewBranch: DiffErrorCulprit;
-      constructorName: string;
-    };
+    tag: "strayConstructor";
+    oldOrNewBranch: DiffErrorCulprit;
+    constructorName: string;
+  };
 
 type ContributionDiffConfig =
   | { tag: "ok" }