Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update ProgressBar to winui3/release/1.4.2 #14288

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

chore: Update ProgressBar to winui3/release/1.4.2 #14288

wants to merge 6 commits into from

Conversation

morning4coffe-dev
Copy link
Member

@morning4coffe-dev morning4coffe-dev commented Nov 5, 2023 •
edited
Loading

GitHub Issue (If applicable): part of #14275

PR Type

What kind of change does this PR introduce?

  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)

What is the current behavior?

What is the new behavior?

Updated the ProgressBar code to match the new public winui3/release/1.4.2

Copilot Summary

🤖 Generated by Copilot at 42ba9f8

This pull request ports the latest version of the MUX ProgressBar control to Uno, by updating the XAML template and the C# code files. It also improves the code structure and readability by splitting the ProgressBar class into partial classes and adding comments.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Docs have been added/updated which fit documentation template (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Validated PR Screenshots Compare Test Run results.
  • (Minor breaking change - ContainerAnimationStartPosition2 -> Container2AnimationStartPosition, same for end position) Contains NO breaking changes
  • Associated with an issue (GitHub or internal) and uses the automatic close keywords.
  • Commits must be following the Conventional Commits specification.

@morning4coffe-dev
Copy link
Member Author

@MartinZikmund Is it ok, if I make this breaking change? The change from the public ContainerAnimationStartPosition2 -> Container2AnimationStartPosition

@MartinZikmund
Copy link
Member

@morning4coffe-dev I think it aligns the API with WinUI3 correct? I think it should be safe here, especially as the TemplateSettings should only be used internally by the control and templates. Can you check if the property is not used in Material somewhere, just for safety?

@morning4coffe-dev
Copy link
Member Author

@MartinZikmund Good. 👍 I searched all of our projects for references and it seems like other styles are using it

@github-actions github-actions bot added the area/build Categorizes an issue or PR as relevant to build infrastructure label Nov 13, 2023
@morning4coffe-dev @MartinZikmund
chore: Update ProgressBar to winui3/release/1.4.2
a8ba481 
# Conflicts:
#	src/Uno.UI/Microsoft/UI/Xaml/Controls/ProgressBar/ProgressBar.cs
#	src/Uno.UI/Microsoft/UI/Xaml/Controls/ProgressBar/ProgressBarAutomationPeer.cs
#	src/Uno.UI/Microsoft/UI/Xaml/Controls/ProgressBar/ProgressBarTemplateSettings.cs
@morning4coffe-dev @MartinZikmund
chore: Update ProgressBar theme to winui3/release/1.4.2
c1e4945
@morning4coffe-dev @MartinZikmund
chore: Update themes for older styles
23d0b8f 
# Conflicts:
#	src/Uno.UI/Microsoft/UI/Xaml/Controls/ProgressBar/ProgressBar.xaml
@morning4coffe-dev @MartinZikmund
chore: Ignore property removal
f4f6a97 
# Conflicts:
#	build/PackageDiffIgnore.xml
@morning4coffe-dev @MartinZikmund
chore: Fix diffignore
ed45470 
# Conflicts:
#	build/PackageDiffIgnore.xml
@MartinZikmund MartinZikmund force-pushed the dev/doti/progressbar-winui3-release-1.4.2 branch from 65047b1 to ed45470 Compare January 11, 2024 16:55
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14288/index.html

@morning4coffe-dev
Copy link
Member Author

CC @MartinZikmund should I close this one?

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or it will be closed in 10 days.

@github-actions github-actions bot added the stale This item has been marked as stale and will be closed if there is no activity. label Jan 30, 2025
@MartinZikmund MartinZikmund removed the stale This item has been marked as stale and will be closed if there is no activity. label Jan 31, 2025
@MartinZikmund MartinZikmund mentioned this pull request Jan 31, 2025
Closed
6 tasks
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14288/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/build Categorizes an issue or PR as relevant to build infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@morning4coffe-dev @MartinZikmund @unodevops