Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GridView+ListView with FeedView] Drag+Drop+Reordering issue with nested in FeedView on desktop target material style #19034

Open
DevTKSS opened this issue Dec 8, 2024 · 4 comments
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification

Comments

@DevTKSS
Copy link
Contributor

DevTKSS commented Dec 8, 2024

Current behavior

FeedView+ListView+GridView+DragDropReorder.mp4
  • strange behavior on drag drop on the left one, its draging the whole element instead of just the ListViewItem, which is a Grid + image+2x TextBlock each Item
  • Both FeedView parent items are fed following the docs guide from same source via Injected Service in the Pages Model

added a example of what I would expect it to do from the WinUI Gallery.

Both FeedView parent items are fed from same Injected Service, which is set up as a IListFeed

strange additionally: running this on a really high performant computer (installed vs 2022 just a few hours ago, with uno etc) is showing the overlays, which I do not expect to happen with that good graphics card

Expected behavior

added the expected behaviour (drag, drop, reorder) at the end of the video, just look the WinUI 3 Gallery up for bot Elements nested in FeedView.
no overlays or uno extension issue like in the video right in the project explorer

How to reproduce it (as minimally and precisely as possible)

See my UnoHotDesignApp1 Repository, please see its Activity Page with the commit history since I did remove/uncommented the here mentioned code parts as workaround.

Side note, just for information, not relevant for solving this drag-drop issue here:
As you will also see there listed performance issues listed, this repository has been kicked because of this from my future developed ones and the code will take place instead in a new created one which is not having this issue of slownes. seems some strange thing in relation with the used uno versions+studio and not happening on new ones, but not going away on this one.

Workaround

its not disabling build, so workaround for me would be, just not to use drag&drop on any of those when having them nested

Works on UWP/WinUI

Windows+Desktop targeted and building, just complaining about unknown publish profile as common known issue

Environment

No response

NuGet package version(s)

No response

Affected platforms

Skia (WPF), Skia (Linux Framebuffer)

IDE

Visual Studio 2022

IDE version

Visual Studio 2022 community 17.12.3, .net 9.0.101

Relevant plugins

No response

Anything else we need to know?

Target Platforms desktop, windows, but none of the windows ones is building, desktop used regulary for the video to be made.

@DevTKSS DevTKSS added difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification labels Dec 8, 2024
@jeromelaban
Copy link
Member

Thanks for the report. Make sure to avoid reporting multiple problem in the same issue.

The overlay issue that you're seeing is fixed by upgrading to SkiaSharp 3. For the others issues, you can close this one and split into other so we can track individually. Thanks!

@DevTKSS
Copy link
Contributor Author

DevTKSS commented Dec 9, 2024

One quick question to your answer with the overlay:
I did not here about this version change and on this is the latest UNO.sdk and all of the other stuff just freshly installed. Maybe you can tell what I have to update additionally?
And to the splitting: bit unsure, how small you want to split it up... Could you make the bit clearer for me so I am doing it like you want it to be?
Maybe for soling this it would be good to share the project, can you tell me if it is all out to make the repo public for review while I am at HotDesign beta?

@jeromelaban
Copy link
Member

You mentioned two behaviors, one for the overlays, the other one for the drag and drop not working properly. The first one is skiasharp related #18299. For the drag and drop, make sure to create a new issue and provide a sample and repro steps. In general, creating a small zip file and attaching it in the issue is good enough.

@DevTKSS DevTKSS changed the title GridView+ListView with FeedView and drag and drop and reordering is not properly working in a desktop target uno project? Strange overlays on high performance maschine from FeedView+GridView [GridView+ListView with FeedView] Drag+Drop+Reordering issue with nested in FeedView on desktop target material style Feb 21, 2025
@DevTKSS
Copy link
Contributor Author

DevTKSS commented Feb 21, 2025

@jeromelaban updated description and added link to the repo, which I checked do correctly not having the bin+obj folders, so should be fine from this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification
Projects
None yet
Development

No branches or pull requests

2 participants