Skip to content

Commit 71b4f77

Browse files
committed
minor
1 parent 56beb89 commit 71b4f77

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

dill/tests/test_stdlib_modules.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -116,15 +116,19 @@ def test_stdlib_modules():
116116
load_total = load_successes + load_failures
117117
dump_percent = 100 * dump_successes / dump_total
118118
load_percent = 100 * load_successes / load_total
119-
print()
120-
print(message % ("dump", refonfail, dump_percent, dump_successes, dump_total))
121-
print(message % ("load", refonfail, load_percent, load_successes, load_total))
119+
if logging.getLogger().isEnabledFor(logging.INFO): print()
120+
logging.info(message, "dump", refonfail, dump_percent, dump_successes, dump_total)
121+
logging.info(message, "load", refonfail, load_percent, load_successes, load_total)
122122
if refonfail:
123123
failed_dump = [mod for mod, (dumped, _) in zip(modules, result) if dumped is False]
124124
failed_load = [mod for mod, (_, loaded) in zip(modules, result) if loaded is False]
125-
logging.info("dump_module() fails: %s", failed_dump)
126-
logging.info("load_module() fails: %s", failed_load)
127-
assert dump_percent > 95
125+
if failed_dump:
126+
logging.info("dump_module() FAILURES: %s", str(failed_dump).replace("'", "")[1:-1])
127+
if failed_load:
128+
logging.info("load_module() FAILURES: %s", str(failed_load).replace("'", "")[1:-1])
129+
assert dump_percent > 99
130+
assert load_percent > 85 #FIXME: many important modules fail to unpickle
131+
print()
128132

129133
if __name__ == '__main__':
130134
logging.basicConfig(level=os.environ.get('PYTHONLOGLEVEL', 'WARNING'))

0 commit comments

Comments
 (0)