Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle numpad enter as ctrl+enter #4354

Open
kuon opened this issue Feb 2, 2025 · 2 comments
Open

Handle numpad enter as ctrl+enter #4354

kuon opened this issue Feb 2, 2025 · 2 comments
Labels
enhancement New feature or request Stale

Comments

@kuon
Copy link

kuon commented Feb 2, 2025

Describe the solution you'd like

At present, we can save a memo by using the Ctrl+Enter key combination.

It would be great if we could also use the numpad enter key.

In javascript, this key can be detected in two ways depending on the operating system.

Properly behaved browser/os, should set the event.code to NumpadEnter and event.location to 3. But not all does both. I think it is safe to check for either.

https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/location

Type of feature

User Interface (UI)

Additional context

Note: if you accept this feature I can do a PR.

@kuon kuon added the enhancement New feature or request label Feb 2, 2025
@RoccoSmit
Copy link
Contributor

Using the numpad Enter as part of Ctrl+Enter works for me. What browser/os are you using?

@kuon
Copy link
Author

kuon commented Feb 5, 2025 via email

@github-actions github-actions bot added the Stale label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

2 participants