feat ydb: extend ydb::CoordinationSession semaphore methods

Updated `ydb::CoordinationSession` semaphore methods (`CreateSemaphore`, `DeleteSemaphore`)

1) **CreateSemaphore**: Added `std::string_view data` argument (default is empty). Allows attaching [user-defined metadata](https://github.com/ydb-platform/ydb/blob/093a5c2d32357ce9957a4cf16c13cc36eb2b6c60/ydb/public/api/protos/ydb_coordination.proto#L264-L265) to the semaphore upon creation. [SDK method](https://github.com/ydb-platform/ydb-cpp-sdk/blob/e091a10085dff2c96f3c99641db83498e7fa2a09/include/ydb-cpp-sdk/client/coordination/coordination.h#L354-L355)
2) **DeleteSemaphore**: Added argument that enables [force deletion](https://github.com/ydb-platform/ydb/blob/093a5c2d32357ce9957a4cf16c13cc36eb2b6c60/ydb/public/api/protos/ydb_coordination.proto#L292-L293) of the semaphore. [SDK method](https://github.com/ydb-platform/ydb-cpp-sdk/blob/e091a10085dff2c96f3c99641db83498e7fa2a09/include/ydb-cpp-sdk/client/coordination/coordination.h#L360-L361)

---

Pull Request resolved: #1114

Co-authored-by: antoshkka <antoshkka@userver.tech>
commit_hash:a1f3a46cb7fa679dcda147f7e50f61c8cbf185e0

Author: 2 people

ydb/include/userver/ydb/coordination.hpp

@@ -61,13 +61,21 @@ class CoordinationSession final {
     );
 
     /// Create semaphore
-    void CreateSemaphore(std::string_view name, std::uint64_t limit);
+    /// @param data user-defined data attached to the semaphore
+    void CreateSemaphore(std::string_view name, std::uint64_t limit, std::string_view data = {});
 
     /// Update semaphore
     void UpdateSemaphore(std::string_view name, std::string_view data);
 
+    /// Semaphore deletion mode
+    enum class Mode {
+        kNormal,  ///< Fail if the semaphore is currently acquired
+        kForce,   ///< Delete even if currently acquired by sessions
+    };
+
     /// Delete semaphore
-    void DeleteSemaphore(std::string_view name);
+    /// @param mode deletion mode; use `Mode::kForce` to delete even if currently acquired
+    void DeleteSemaphore(std::string_view name, Mode mode = Mode::kNormal);
 
 private:
     NYdb::NCoordination::TSession session_;

ydb/src/ydb/coordination.cpp

@@ -56,16 +56,16 @@ NYdb::NCoordination::TSemaphoreDescription CoordinationSession::DescribeSemaphor
     return ExtractResult(session_.DescribeSemaphore(impl::ToString(name), settings), "DescribeSemaphore");
 }
 
-void CoordinationSession::CreateSemaphore(std::string_view name, std::uint64_t limit) {
-    ExtractResult(session_.CreateSemaphore(impl::ToString(name), limit), "CreateSemaphore");
+void CoordinationSession::CreateSemaphore(std::string_view name, std::uint64_t limit, std::string_view data) {
+    ExtractResult(session_.CreateSemaphore(impl::ToString(name), limit, impl::ToString(data)), "CreateSemaphore");
 }
 
 void CoordinationSession::UpdateSemaphore(std::string_view name, std::string_view data) {
     ExtractResult(session_.UpdateSemaphore(impl::ToString(name), impl::ToString(data)), "UpdateSemaphore");
 }
 
-void CoordinationSession::DeleteSemaphore(std::string_view name) {
-    ExtractResult(session_.DeleteSemaphore(impl::ToString(name)), "DeleteSemaphore");
+void CoordinationSession::DeleteSemaphore(std::string_view name, Mode mode) {
+    ExtractResult(session_.DeleteSemaphore(impl::ToString(name), mode == Mode::kForce), "DeleteSemaphore");
 }
 
 CoordinationClient::CoordinationClient(std::shared_ptr<impl::Driver> driver)

ydb/tests/coordination_test.cpp

@@ -73,6 +73,38 @@ UTEST_F(YdbCoordinationFixture, CreateSemaphore) {
     UASSERT_THROW(session.DescribeSemaphore(kSemaphoreName, {}), ydb::YdbResponseError);
 }
 
+UTEST_F(YdbCoordinationFixture, CreateSemaphoreWithData) {
+    auto session = StartSession(kCoordinationNode);
+
+    constexpr std::string_view semaphore_data = "test_semaphore_data";
+    UASSERT_NO_THROW(session.CreateSemaphore(kSemaphoreName, kSemaphoreLimit, semaphore_data));
+
+    NYdb::NCoordination::TSemaphoreDescription desc;
+    UASSERT_NO_THROW(desc = session.DescribeSemaphore(kSemaphoreName, {}));
+    EXPECT_EQ(kSemaphoreName, desc.GetName());
+    EXPECT_EQ(semaphore_data, desc.GetData());
+    EXPECT_EQ(kSemaphoreLimit, desc.GetLimit());
+
+    UASSERT_NO_THROW(session.DeleteSemaphore(kSemaphoreName));
+}
+
+UTEST_F(YdbCoordinationFixture, DeleteSemaphoreForce) {
+    auto session = StartSession(kCoordinationNode);
+    UASSERT_NO_THROW(session.CreateSemaphore(kSemaphoreName, kSemaphoreLimit));
+
+    ASSERT_TRUE(session.AcquireSemaphore(
+        kSemaphoreName,
+        NYdb::NCoordination::TAcquireSemaphoreSettings{}.Count(kSemaphoreLimit)
+    ));
+
+    UASSERT_THROW(
+        session.DeleteSemaphore(kSemaphoreName, ydb::CoordinationSession::Mode::kNormal),
+        ydb::YdbResponseError
+    );
+    UASSERT_NO_THROW(session.DeleteSemaphore(kSemaphoreName, ydb::CoordinationSession::Mode::kForce));
+    UASSERT_THROW(session.DescribeSemaphore(kSemaphoreName, {}), ydb::YdbResponseError);
+}
+
 UTEST_F(YdbCoordinationFixture, UpdateSemaphore) {
     auto session = StartSession(kCoordinationNode);
     UASSERT_NO_THROW(session.CreateSemaphore(kSemaphoreName, kSemaphoreLimit));