Skip to content

Commit 5518ddc

Browse files
committed
Merge remote-tracking branch 'origin/bugfix/10.5.18/add-compliance' into bugfix/10.5.18/add-compliance
2 parents 39e1d1c + f46ab8f commit 5518ddc

File tree

9 files changed

+28
-22
lines changed

9 files changed

+28
-22
lines changed

frontend/src/app/compliance/compliance-report-viewer/compliance-report-viewer.component.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ export class ComplianceReportViewerComponent implements OnInit, AfterViewInit, O
3535
activeSection: ComplianceStandardSectionType = null;
3636
pageable = {
3737
page: 0,
38-
size: 15
38+
size: 15,
39+
sort: 'configReportName,desc'
3940
};
4041
viewportHeight: number;
4142

@@ -188,7 +189,8 @@ export class ComplianceReportViewerComponent implements OnInit, AfterViewInit, O
188189
standardId: this.activeSection.standardId,
189190
id: this.activeSection.id,
190191
page: this.pageable.page,
191-
size: this.pageable.size
192+
size: this.pageable.size,
193+
sort: this.pageable.sort
192194
}));
193195
}
194196

frontend/src/app/compliance/compliance-reports-view/compliance-reports-view.component.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,8 @@ export class ComplianceReportsViewComponent implements OnInit, OnChanges, OnDest
120120
});
121121
this.pageChange.emit({
122122
page,
123-
size: this.itemsPerPage
123+
size: this.itemsPerPage,
124+
sort: this.sort
124125
});
125126
}
126127

frontend/src/app/compliance/compliance-reports-view/components/compliance-print-view/compliance-print-view.component.ts

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
1+
import { HttpErrorResponse } from '@angular/common/http';
12
import {ChangeDetectionStrategy, Component, Input, OnDestroy, OnInit, Output} from '@angular/core';
3+
import { ActivatedRoute } from '@angular/router';
24
import {EMPTY, Observable} from 'rxjs';
35
import {catchError, concatMap, filter, map, takeUntil, tap} from 'rxjs/operators';
4-
import { ComplianceReportType } from '../../../shared/type/compliance-report.type';
5-
import { HttpErrorResponse } from '@angular/common/http';
66
import { CpReportsService } from 'src/app/compliance/shared/services/cp-reports.service';
77
import { ComplianceStandardSectionType } from 'src/app/compliance/shared/type/compliance-standard-section.type';
88
import { UtmToastService } from 'src/app/shared/alert/utm-toast.service';
99
import { SortByType } from 'src/app/shared/types/sort-by.type';
10-
import { ActivatedRoute } from '@angular/router';
10+
import { ComplianceReportType } from '../../../shared/type/compliance-report.type';
1111

1212

1313
@Component({
@@ -22,8 +22,6 @@ export class CompliancePrintViewComponent implements OnInit, OnDestroy {
2222
reports$: Observable<ComplianceReportType[]>;
2323
selected: number;
2424
fields: SortByType[];
25-
26-
reportDetail: ComplianceReportType;
2725
preparingPrint = true;
2826

2927
constructor(private reportsService: CpReportsService,
@@ -42,6 +40,8 @@ export class CompliancePrintViewComponent implements OnInit, OnDestroy {
4240
standardId: this.section.standardId,
4341
sectionId: this.section.id,
4442
expandDashboard: true,
43+
setStatus: true,
44+
sort: params.sort,
4545
})),
4646
map((res) => {
4747
return res.body.map((r, index) => {
@@ -62,13 +62,11 @@ export class CompliancePrintViewComponent implements OnInit, OnDestroy {
6262
report.visualization = visualization;
6363
}
6464

65-
ngOnDestroy(): void {
66-
throw new Error('Method not implemented.');
67-
}
68-
6965
onVisualizationLoaded(){
7066
this.preparingPrint = false;
7167
}
7268

73-
69+
ngOnDestroy(): void {
70+
throw new Error('Method not implemented.');
71+
}
7472
}

frontend/src/app/compliance/compliance-reports-view/components/compliance-report-detail/compliance-report-detail.component.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,10 @@ export class ComplianceReportDetailComponent implements OnInit {
4444
this.compliance$ = this.utmRenderVisualization.onRefresh$
4545
.pipe(
4646
filter((refresh) => !!refresh),
47-
concatMap(() => this.runVisualization.run(this.vis)),
47+
concatMap(() => this.runVisualization.run(this.vis, {
48+
page: 0,
49+
size: 5,
50+
})),
4851
map(run => run[0] && run[0] ? run[0] : {
4952
rows: []
5053
}),

frontend/src/app/compliance/compliance-result-view/compliance-result-view.component.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,5 @@ export class ComplianceResultViewComponent implements OnInit, OnDestroy {
184184
ngOnDestroy() {
185185
this.destroy$.next();
186186
this.destroy$.complete();
187-
console.log('destroy!!!');
188187
}
189188
}

frontend/src/app/graphic-builder/shared/components/viewer/table-view/table-view.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@
118118
[size]="'sm'"></ngb-pagination>
119119
</div>
120120
</div>
121-
<div *ngIf="!data || !data.rows" class="h-100 w-100 p-5 d-flex justify-content-center align-items-center">
121+
<div *ngIf="!loadingOption && (!data || !data.rows)" class="h-100 w-100 p-5 d-flex justify-content-center align-items-center">
122122
<app-no-data-chart [error]="false" [typeChart]="chart"></app-no-data-chart>
123123
</div>
124124
</div>

frontend/src/app/graphic-builder/shared/components/viewer/table-view/table-view.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export class TableViewComponent implements OnInit, AfterViewInit, OnChanges {
4545
*/
4646
@Input() exportFormat: boolean;
4747
@Output() runned = new EventEmitter<string>();
48-
@Input() loadingOption = true;
48+
@Input() loadingOption = false;
4949
@Input() chart: ChartTypeEnum;
5050
@Input() width: string;
5151
@Input() height: string;

frontend/src/app/graphic-builder/shared/services/run-visualization.service.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import {Injectable} from '@angular/core';
22
import {Observable} from 'rxjs';
33
import {VisualizationType} from '../../../shared/chart/types/visualization.type';
44
import {VisualizationService} from '../../visualization/shared/services/visualization.service';
5+
import {createRequestOption} from "../../../shared/util/request-util";
56

67
@Injectable({
78
providedIn: 'root'
@@ -14,16 +15,18 @@ export class RunVisualizationService {
1415
/**
1516
* Method return observable of visualization run response
1617
* @param visualization Visualization to run
18+
* @param request optional pagination
1719
*/
18-
run(visualization: VisualizationType): Observable<any> {
20+
run(visualization: VisualizationType, request: any = {}): Observable<any> {
21+
const req = createRequestOption(request);
1922
return new Observable<any>(subscriber => {
2023
if (typeof visualization.chartConfig !== 'string') {
2124
visualization.chartConfig = JSON.stringify(visualization.chartConfig);
2225
}
2326
if (typeof visualization.chartAction !== 'string') {
2427
visualization.chartAction = JSON.stringify(visualization.chartAction);
2528
}
26-
this.visualizationService.run(visualization).subscribe(resp => {
29+
this.visualizationService.run(visualization, req).subscribe(resp => {
2730
if (typeof visualization.chartConfig === 'string') {
2831
visualization.chartConfig = JSON.parse(visualization.chartConfig);
2932
}

frontend/src/app/graphic-builder/visualization/shared/services/visualization.service.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {HttpClient, HttpResponse} from '@angular/common/http';
1+
import {HttpClient, HttpParams, HttpResponse} from '@angular/common/http';
22
import {Injectable} from '@angular/core';
33
import {Observable} from 'rxjs';
44
import {SERVER_API_URL} from '../../../../app.constants';
@@ -42,8 +42,8 @@ export class VisualizationService {
4242
return this.http.delete(this.resourceUrl + '/bulk-delete/' + visualizations, {observe: 'response'});
4343
}
4444

45-
run(visualization: VisualizationType): Observable<HttpResponse<any>> {
46-
return this.http.post<VisualizationType>(this.resourceUrl + '/run', visualization, {observe: 'response'});
45+
run(visualization: VisualizationType, params: HttpParams): Observable<HttpResponse<any>> {
46+
return this.http.post<VisualizationType>(this.resourceUrl + '/run', visualization, {params, observe: 'response'});
4747
}
4848

4949
bulkImport(visualizations: { visualizations: VisualizationType[], override: boolean }) {

0 commit comments

Comments
 (0)