Skip to content

Commit bde0e3b

Browse files
committed
fix: streamline loading state management in playbook service and clean up filter parameters in playbooks component
Signed-off-by: Manuel Abascal <[email protected]>
1 parent 9a3b635 commit bde0e3b

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

frontend/src/app/incident-response/playbooks/playbooks.component.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@ export class PlaybooksComponent implements OnInit, AfterViewInit, OnDestroy {
3232
sort: '',
3333
'active.equals': null,
3434
'agentPlatform.equals': null,
35-
'createdBy.equals': null,
36-
'systemOwner.equals': false
35+
'createdBy.equals': null
3736
};
3837
platforms: string[];
3938
users: string[];

frontend/src/app/incident-response/shared/services/playbook.service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export class PlaybookService {
2020
playbooks$ = this.request$.pipe(
2121
filter(request => !!request),
2222
switchMap(request => {
23-
setTimeout(() => this.loading.next(true), 300);
23+
this.loading.next(true);
2424
return this.incidentResponseRuleService.query(request).pipe(
2525
map(response => {
2626
this.totalItems.next(Number(response.headers.get('X-Total-Count')));
@@ -30,7 +30,7 @@ export class PlaybookService {
3030
this.utmToastService.showError('Error', 'An error occurred while fetching playbooks.');
3131
return of([]);
3232
}),
33-
finalize(() => setTimeout(() => this.loading.next(false), 200))
33+
finalize(() => this.loading.next(false))
3434
);
3535
})
3636
);

0 commit comments

Comments
 (0)