Skip to content

Commit 024c66a

Browse files
Fix review comments
1 parent 7e14981 commit 024c66a

5 files changed

+10
-6
lines changed

include/oneapi/dpl/internal/scan_by_segment_impl.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ struct __sycl_scan_by_segment_impl
117117
// We should avoid using _ExecutionPolicy in __kernel_name_generator template params
118118
// because we always specialize this operator() calls only by _ExecutionPolicy as "const reference".
119119
// So, from this template param point of view, only one specialization is possible per concrete _ExecutionPolicy type.
120-
// _ExecutionPolicy type information is encoded in _CustomName to distinguish between concrete policy types.
120+
// _ExecutionPolicy type information is embedded in _CustomName to distinguish between concrete policy types.
121121
using _SegScanWgKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator<
122122
_SegScanWgPhase, _CustomName, _Range1, _Range2, _Range3, _BinaryPredicate, _BinaryOperator>;
123123
using _SegScanPrefixKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator<

include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h

+2-1
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,8 @@ struct __parallel_scan_submitter<_CustomName, __internal::__optional_kernel_name
242242

243243
// We should avoid using _ExecutionPolicy in __kernel_name_generator template params
244244
// because we always specialize this operator() calls only by _ExecutionPolicy as "const reference".
245-
// So, from this template param point of view, only one specialization is possible.
245+
// So, from this template param point of view, only one specialization is possible per concrete _ExecutionPolicy type.
246+
// _ExecutionPolicy type information is embedded in _CustomName to distinguish between concrete policy types.
246247
using _LocalScanKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator<
247248
__scan_local_kernel, _CustomName, _Range1, _Range2, _Type, _LocalScan, _GroupScan, _GlobalScan>;
248249
using _GroupScanKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator<

include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_radix_sort.h

+2-1
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,8 @@ struct __parallel_radix_sort_iteration
655655

656656
// We should avoid using _ExecutionPolicy in __kernel_name_generator template params
657657
// because we always specialize this submit() calls only by _ExecutionPolicy as "const reference".
658-
// So, from this template param point of view, only one specialization is possible.
658+
// So, from this template param point of view, only one specialization is possible per concrete _ExecutionPolicy type.
659+
// _ExecutionPolicy type information is embedded in _CustomName to distinguish between concrete policy types.
659660
using _RadixCountKernel =
660661
__internal::__kernel_name_generator<__count_phase, _CustomName, std::decay_t<_InRange>,
661662
std::decay_t<_TmpBuf>, _Proj>;

include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_reduce.h

+2-1
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,8 @@ struct __parallel_transform_reduce_impl
322322

323323
// We should avoid using _ExecutionPolicy in __kernel_name_generator template params
324324
// because we always specialize this submit() calls only by _ExecutionPolicy as "const reference".
325-
// So, from this template param point of view, only one specialization is possible.
325+
// So, from this template param point of view, only one specialization is possible per concrete _ExecutionPolicy type.
326+
// _ExecutionPolicy type information is embedded in _CustomName to distinguish between concrete policy types.
326327
using _ReduceKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator<
327328
__reduce_kernel, _CustomName, _ReduceOp, _TransformOp, _NoOpFunctor, _Ranges...>;
328329

include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_reduce_by_segment.h

+3-2
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,9 @@ __parallel_reduce_by_segment_fallback(oneapi::dpl::__internal::__device_backend_
9898
using _CustomName = oneapi::dpl::__internal::__policy_kernel_name<_ExecutionPolicy>;
9999

100100
// We should avoid using _ExecutionPolicy in __kernel_name_generator template params
101-
// because we always specialize this __parallel_reduce_by_segment_fallback calls only by _ExecutionPolicy as "const reference".
102-
// So, from this template param point of view, only one specialization is possible.
101+
// because we always specialize this __parallel_reduce_by_segment_fallback() calls only by _ExecutionPolicy as "const reference".
102+
// So, from this template param point of view, only one specialization is possible per concrete _ExecutionPolicy type.
103+
// _ExecutionPolicy type information is embedded in _CustomName to distinguish between concrete policy types.
103104
using _SegReduceCountKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator<
104105
_SegReduceCountPhase, _CustomName, _Range1, _Range2, _Range3, _Range4, _BinaryPredicate, _BinaryOperator>;
105106
using _SegReduceOffsetKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator<

0 commit comments

Comments
 (0)