Skip to content

Commit a142f1d

Browse files
Mark places with potential problems
1 parent 84da6ac commit a142f1d

5 files changed

+13
-13
lines changed

include/oneapi/dpl/internal/scan_by_segment_impl.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -113,10 +113,10 @@ struct __sycl_scan_by_segment_impl
113113
{
114114
using _CustomName = oneapi::dpl::__internal::__policy_kernel_name<_ExecutionPolicy>;
115115

116-
using _SegScanWgKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator<
116+
using _SegScanWgKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator< // KSATODO: __kernel_name_generator with _ExecutionPolicy - __sycl_scan_by_segment_impl
117117
_SegScanWgPhase, _CustomName, _ExecutionPolicy, _Range1, _Range2, _Range3, _BinaryPredicate,
118118
_BinaryOperator>;
119-
using _SegScanPrefixKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator<
119+
using _SegScanPrefixKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator< // KSATODO: __kernel_name_generator with _ExecutionPolicy - __sycl_scan_by_segment_impl
120120
_SegScanPrefixPhase, _CustomName, _ExecutionPolicy, _Range1, _Range2, _Range3, _BinaryPredicate,
121121
_BinaryOperator>;
122122

include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -239,9 +239,9 @@ struct __parallel_scan_submitter<_CustomName, __internal::__optional_kernel_name
239239
_LocalScan __local_scan, _GroupScan __group_scan, _GlobalScan __global_scan) const
240240
{
241241
using _Type = typename _InitType::__value_type;
242-
using _LocalScanKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator<
242+
using _LocalScanKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator< // KSATODO: __kernel_name_generator w/o _ExecutionPolicy - __parallel_scan_submitter
243243
__scan_local_kernel, _CustomName, _Range1, _Range2, _Type, _LocalScan, _GroupScan, _GlobalScan>;
244-
using _GroupScanKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator<
244+
using _GroupScanKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator< // KSATODO: __kernel_name_generator w/o _ExecutionPolicy - __parallel_scan_submitter
245245
__scan_group_kernel, _CustomName, _Range1, _Range2, _Type, _LocalScan, _GroupScan, _GlobalScan>;
246246
auto __n = __rng1.size();
247247
assert(__n > 0);

include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_radix_sort.h

+4-4
Original file line numberDiff line numberDiff line change
@@ -654,15 +654,15 @@ struct __parallel_radix_sort_iteration
654654
{
655655
using _CustomName = oneapi::dpl::__internal::__policy_kernel_name<_ExecutionPolicy>;
656656
using _RadixCountKernel =
657-
__internal::__kernel_name_generator<__count_phase, _CustomName, _ExecutionPolicy, ::std::decay_t<_InRange>,
657+
__internal::__kernel_name_generator<__count_phase, _CustomName, _ExecutionPolicy, ::std::decay_t<_InRange>, // KSATODO: __kernel_name_generator with _ExecutionPolicy - __parallel_radix_sort_iteration
658658
::std::decay_t<_TmpBuf>, _Proj>;
659-
using _RadixLocalScanKernel = __internal::__kernel_name_generator<__local_scan_phase, _CustomName,
659+
using _RadixLocalScanKernel = __internal::__kernel_name_generator<__local_scan_phase, _CustomName, // KSATODO: __kernel_name_generator with _ExecutionPolicy - __parallel_radix_sort_iteration
660660
_ExecutionPolicy, ::std::decay_t<_TmpBuf>>;
661661
using _RadixReorderPeerKernel =
662-
__internal::__kernel_name_generator<__reorder_peer_phase, _CustomName, _ExecutionPolicy,
662+
__internal::__kernel_name_generator<__reorder_peer_phase, _CustomName, _ExecutionPolicy, // KSATODO: __kernel_name_generator with _ExecutionPolicy - __parallel_radix_sort_iteration
663663
::std::decay_t<_InRange>, ::std::decay_t<_OutRange>, _Proj>;
664664
using _RadixReorderKernel =
665-
__internal::__kernel_name_generator<__reorder_phase, _CustomName, _ExecutionPolicy,
665+
__internal::__kernel_name_generator<__reorder_phase, _CustomName, _ExecutionPolicy, // KSATODO: __kernel_name_generator with _ExecutionPolicy - __parallel_radix_sort_iteration
666666
::std::decay_t<_InRange>, ::std::decay_t<_OutRange>, _Proj>;
667667

668668
::std::size_t __max_sg_size = oneapi::dpl::__internal::__max_sub_group_size(__exec);

include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_reduce.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,7 @@ struct __parallel_transform_reduce_impl
318318
{
319319
using _CustomName = oneapi::dpl::__internal::__policy_kernel_name<_ExecutionPolicy>;
320320
using _NoOpFunctor = unseq_backend::walk_n<_ExecutionPolicy, oneapi::dpl::__internal::__no_op>;
321-
using _ReduceKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator<
321+
using _ReduceKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator< // KSATODO: __kernel_name_generator w/o _ExecutionPolicy - __parallel_transform_reduce_impl
322322
__reduce_kernel, _CustomName, _ReduceOp, _TransformOp, _NoOpFunctor, _Ranges...>;
323323

324324
auto __transform_pattern1 =

include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_reduce_by_segment.h

+4-4
Original file line numberDiff line numberDiff line change
@@ -97,16 +97,16 @@ __parallel_reduce_by_segment_fallback(oneapi::dpl::__internal::__device_backend_
9797
{
9898
using _CustomName = oneapi::dpl::__internal::__policy_kernel_name<_ExecutionPolicy>;
9999

100-
using _SegReduceCountKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator<
100+
using _SegReduceCountKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator< // KSATODO: __kernel_name_generator with _ExecutionPolicy - __parallel_reduce_by_segment_fallback
101101
_SegReduceCountPhase, _CustomName, _ExecutionPolicy, _Range1, _Range2, _Range3, _Range4, _BinaryPredicate,
102102
_BinaryOperator>;
103-
using _SegReduceOffsetKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator<
103+
using _SegReduceOffsetKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator< // KSATODO: __kernel_name_generator with _ExecutionPolicy - __parallel_reduce_by_segment_fallback
104104
_SegReduceOffsetPhase, _CustomName, _ExecutionPolicy, _Range1, _Range2, _Range3, _Range4, _BinaryPredicate,
105105
_BinaryOperator>;
106-
using _SegReduceWgKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator<
106+
using _SegReduceWgKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator< // KSATODO: __kernel_name_generator with _ExecutionPolicy - __parallel_reduce_by_segment_fallback
107107
_SegReduceWgPhase, _CustomName, _ExecutionPolicy, _Range1, _Range2, _Range3, _Range4, _BinaryPredicate,
108108
_BinaryOperator>;
109-
using _SegReducePrefixKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator<
109+
using _SegReducePrefixKernel = oneapi::dpl::__par_backend_hetero::__internal::__kernel_name_generator< // KSATODO: __kernel_name_generator with _ExecutionPolicy - __parallel_reduce_by_segment_fallback
110110
_SegReducePrefixPhase, _CustomName, _ExecutionPolicy, _Range1, _Range2, _Range3, _Range4, _BinaryPredicate,
111111
_BinaryOperator>;
112112

0 commit comments

Comments
 (0)