Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort test: check type requirements conformance (device policies) #2103

Open
dmitriy-sobolev opened this issue Mar 5, 2025 · 0 comments
Open
Labels
test Test only Change

Comments

@dmitriy-sobolev
Copy link
Contributor

dmitriy-sobolev commented Mar 5, 2025

Summary:

C++ standards sets these type preconditions:

Preconditions: For the overloads in namespace std, RandomAccessIterator meets the Cpp17ValueSwappable requirements ([swappable.requirements]) and the type of *first meets the Cpp17MoveConstructible (Table 31) and Cpp17MoveAssignable (Table 33) requirements.

Sort tests do not check if it is sufficient when using a device policy (for example, it does not require CopyConstructible). This check is needed.

There is a TODO in the test:

// TODO: add a test for a MoveConstructible only type

@dmitriy-sobolev dmitriy-sobolev added the test Test only Change label Mar 5, 2025
@dmitriy-sobolev dmitriy-sobolev changed the title Sort test: check type requirements conformance with device policies Sort test: check type requirements conformance (device policies) Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Test only Change
Projects
None yet
Development

No branches or pull requests

1 participant