Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable is not defined #2107

Open
SergeyKopienko opened this issue Mar 6, 2025 · 1 comment
Open

Variable is not defined #2107

SergeyKopienko opened this issue Mar 6, 2025 · 1 comment

Comments

@SergeyKopienko
Copy link
Contributor

Variable policy1 is not defined at

replace_copy_if(policy1, first2, last2 - 1, _flags.get() + 1, _temp.get() + 1, ::std::negate<FlagType>(), init);

in the next code:

    // TODO : add stencil form of replace_copy_if to oneDPL if the
    // transform call here is difficult to understand and maintain.
#if 1
    // ...
#else
    replace_copy_if(policy1, first2, last2 - 1, _flags.get() + 1, _temp.get() + 1, ::std::negate<FlagType>(), init);
#endif

But its use simple hidden under macro definition checks so we haven't any compile-time errors.

@mmichel11
Copy link
Contributor

This code will also never compile with oneDPL if policy1 did exist since it is using a form of replace_copy_if that is an extension to the C++ spec that we only provide in compatibility headers.

In my opinion, we can just remove it as it's been here since 2020, and I don't think there are any plans to provide such APIs directly into oneDPL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants