Skip to content

Commit 36722de

Browse files
committed
Review comments.
1 parent 35b0234 commit 36722de

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

Jenkinsfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
buildPlugin()
1+
buildPlugin(jenkinsVersions: [null, '2.121.1'])

src/main/resources/org/jenkinsci/plugins/workflow/steps/durable_task/DurableTaskStep/help-encoding.html

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,11 @@
22
Encoding of process output.
33
In the case of <code>returnStdout</code>, applies to the return value of this step;
44
otherwise, or always for standard error, controls how text is copied to the build log.
5-
If unspecified, uses the system default encoding of the node on which the step is run,
6-
but if there is any expectation that process output might include non-ASCII characters,
5+
If unspecified, uses the system default encoding of the node on which the step is run.
6+
If there is any expectation that process output might include non-ASCII characters,
77
it is best to specify the encoding explicitly.
8+
For example, if you have specific knowledge that a given process is going to be producing UTF-8
9+
yet will be running on a node with a different system encoding
10+
(typically Windows, since every Linux distribution has defaulted to UTF-8 for a long time),
11+
you can ensure correct output by specifying: <code>encoding: 'UTF-8'</code>
812
</div>

0 commit comments

Comments
 (0)