From 09e8f772462fd638464b1b16498b9f7b547619bf Mon Sep 17 00:00:00 2001 From: Diego Cardoso Date: Mon, 3 Nov 2025 18:24:06 +0100 Subject: [PATCH 1/2] fix: move tooltip slot to field container (#10410) (#10421) --- packages/combo-box/src/vaadin-combo-box.js | 4 ++-- .../dom/__snapshots__/combo-box.test.snap.js | 20 ++++++++-------- .../date-picker/src/vaadin-date-picker.js | 4 ++-- .../__snapshots__/date-picker.test.snap.js | 20 ++++++++-------- .../__snapshots__/email-field.test.snap.js | 20 ++++++++-------- .../__snapshots__/integer-field.test.snap.js | 24 +++++++++---------- .../src/vaadin-multi-select-combo-box.js | 4 ++-- .../multi-select-combo-box.test.snap.js | 16 ++++++------- .../number-field/src/vaadin-number-field.js | 4 ++-- .../__snapshots__/number-field.test.snap.js | 24 +++++++++---------- .../__snapshots__/password-field.test.snap.js | 20 ++++++++-------- packages/text-area/src/vaadin-text-area.js | 4 ++-- .../dom/__snapshots__/text-area.test.snap.js | 20 ++++++++-------- packages/text-field/src/vaadin-text-field.js | 3 ++- .../dom/__snapshots__/text-field.test.snap.js | 20 ++++++++-------- .../time-picker/src/vaadin-time-picker.js | 3 ++- .../__snapshots__/time-picker.test.snap.js | 20 ++++++++-------- 17 files changed, 116 insertions(+), 114 deletions(-) diff --git a/packages/combo-box/src/vaadin-combo-box.js b/packages/combo-box/src/vaadin-combo-box.js index 4b2a200e5e3..16afda28666 100644 --- a/packages/combo-box/src/vaadin-combo-box.js +++ b/packages/combo-box/src/vaadin-combo-box.js @@ -197,6 +197,8 @@ class ComboBox extends ComboBoxDataProviderMixin(
+ + - - `; } diff --git a/packages/combo-box/test/dom/__snapshots__/combo-box.test.snap.js b/packages/combo-box/test/dom/__snapshots__/combo-box.test.snap.js index d82effc758c..fb9e55a2c28 100644 --- a/packages/combo-box/test/dom/__snapshots__/combo-box.test.snap.js +++ b/packages/combo-box/test/dom/__snapshots__/combo-box.test.snap.js @@ -527,6 +527,8 @@ snapshots["vaadin-combo-box shadow default"] = + + - - `; /* end snapshot vaadin-combo-box shadow default */ @@ -588,6 +588,8 @@ snapshots["vaadin-combo-box shadow disabled"] = + + - - `; /* end snapshot vaadin-combo-box shadow disabled */ @@ -649,6 +649,8 @@ snapshots["vaadin-combo-box shadow readonly"] = + + - - `; /* end snapshot vaadin-combo-box shadow readonly */ @@ -710,6 +710,8 @@ snapshots["vaadin-combo-box shadow invalid"] = + + - - `; /* end snapshot vaadin-combo-box shadow invalid */ @@ -771,6 +771,8 @@ snapshots["vaadin-combo-box shadow theme"] = + + - - `; /* end snapshot vaadin-combo-box shadow theme */ diff --git a/packages/date-picker/src/vaadin-date-picker.js b/packages/date-picker/src/vaadin-date-picker.js index 517e93f5f1c..3227177d3d9 100644 --- a/packages/date-picker/src/vaadin-date-picker.js +++ b/packages/date-picker/src/vaadin-date-picker.js @@ -183,6 +183,8 @@ class DatePicker extends DatePickerMixin(InputControlMixin(ThemableMixin(Element
+ + - - `; } diff --git a/packages/date-picker/test/dom/__snapshots__/date-picker.test.snap.js b/packages/date-picker/test/dom/__snapshots__/date-picker.test.snap.js index f40ba100dd4..14562dd9adb 100644 --- a/packages/date-picker/test/dom/__snapshots__/date-picker.test.snap.js +++ b/packages/date-picker/test/dom/__snapshots__/date-picker.test.snap.js @@ -830,14 +830,14 @@ snapshots["vaadin-date-picker shadow default"] = + + - - `; /* end snapshot vaadin-date-picker shadow default */ @@ -885,14 +885,14 @@ snapshots["vaadin-date-picker shadow disabled"] = + + - - `; /* end snapshot vaadin-date-picker shadow disabled */ @@ -940,14 +940,14 @@ snapshots["vaadin-date-picker shadow readonly"] = + + - - `; /* end snapshot vaadin-date-picker shadow readonly */ @@ -995,14 +995,14 @@ snapshots["vaadin-date-picker shadow invalid"] = + + - - `; /* end snapshot vaadin-date-picker shadow invalid */ @@ -1050,6 +1050,8 @@ snapshots["vaadin-date-picker shadow theme"] = + + - - `; /* end snapshot vaadin-date-picker shadow theme */ diff --git a/packages/email-field/test/dom/__snapshots__/email-field.test.snap.js b/packages/email-field/test/dom/__snapshots__/email-field.test.snap.js index 16b1df86a0b..98f8f5e4fdf 100644 --- a/packages/email-field/test/dom/__snapshots__/email-field.test.snap.js +++ b/packages/email-field/test/dom/__snapshots__/email-field.test.snap.js @@ -125,9 +125,9 @@ snapshots["vaadin-email-field shadow default"] = + + - - `; /* end snapshot vaadin-email-field shadow default */ @@ -174,9 +174,9 @@ snapshots["vaadin-email-field shadow disabled"] = + + - - `; /* end snapshot vaadin-email-field shadow disabled */ @@ -223,9 +223,9 @@ snapshots["vaadin-email-field shadow readonly"] = + + - - `; /* end snapshot vaadin-email-field shadow readonly */ @@ -272,9 +272,9 @@ snapshots["vaadin-email-field shadow invalid"] = + + - - `; /* end snapshot vaadin-email-field shadow invalid */ @@ -321,9 +321,9 @@ snapshots["vaadin-email-field shadow theme"] = + + - - `; /* end snapshot vaadin-email-field shadow theme */ diff --git a/packages/integer-field/test/dom/__snapshots__/integer-field.test.snap.js b/packages/integer-field/test/dom/__snapshots__/integer-field.test.snap.js index 3aafc8ca0f1..69dabdbcc00 100644 --- a/packages/integer-field/test/dom/__snapshots__/integer-field.test.snap.js +++ b/packages/integer-field/test/dom/__snapshots__/integer-field.test.snap.js @@ -146,9 +146,9 @@ snapshots["vaadin-integer-field shadow default"] = + + - - `; /* end snapshot vaadin-integer-field shadow default */ @@ -204,9 +204,9 @@ snapshots["vaadin-integer-field shadow step-buttons-visible"] = + + - - `; /* end snapshot vaadin-integer-field shadow step-buttons-visible */ @@ -267,9 +267,9 @@ snapshots["vaadin-integer-field shadow disabled"] = + + - - `; /* end snapshot vaadin-integer-field shadow disabled */ @@ -330,9 +330,9 @@ snapshots["vaadin-integer-field shadow readonly"] = + + - - `; /* end snapshot vaadin-integer-field shadow readonly */ @@ -393,9 +393,9 @@ snapshots["vaadin-integer-field shadow invalid"] = + + - - `; /* end snapshot vaadin-integer-field shadow invalid */ @@ -456,9 +456,9 @@ snapshots["vaadin-integer-field shadow theme"] = + + - - `; /* end snapshot vaadin-integer-field shadow theme */ diff --git a/packages/multi-select-combo-box/src/vaadin-multi-select-combo-box.js b/packages/multi-select-combo-box/src/vaadin-multi-select-combo-box.js index 2cff79f180e..1e69569487e 100644 --- a/packages/multi-select-combo-box/src/vaadin-multi-select-combo-box.js +++ b/packages/multi-select-combo-box/src/vaadin-multi-select-combo-box.js @@ -175,9 +175,9 @@ class MultiSelectComboBox extends MultiSelectComboBoxMixin(ThemableMixin(Element
- - + + `; } } diff --git a/packages/multi-select-combo-box/test/dom/__snapshots__/multi-select-combo-box.test.snap.js b/packages/multi-select-combo-box/test/dom/__snapshots__/multi-select-combo-box.test.snap.js index 7e197172344..e76f9b4156b 100644 --- a/packages/multi-select-combo-box/test/dom/__snapshots__/multi-select-combo-box.test.snap.js +++ b/packages/multi-select-combo-box/test/dom/__snapshots__/multi-select-combo-box.test.snap.js @@ -438,9 +438,9 @@ snapshots["vaadin-multi-select-combo-box shadow default"] = + + - - `; /* end snapshot vaadin-multi-select-combo-box shadow default */ @@ -504,9 +504,9 @@ snapshots["vaadin-multi-select-combo-box shadow disabled"] = + + - - `; /* end snapshot vaadin-multi-select-combo-box shadow disabled */ @@ -569,9 +569,9 @@ snapshots["vaadin-multi-select-combo-box shadow readonly"] = + + - - `; /* end snapshot vaadin-multi-select-combo-box shadow readonly */ @@ -631,9 +631,9 @@ snapshots["vaadin-multi-select-combo-box shadow invalid"] = + + - - `; /* end snapshot vaadin-multi-select-combo-box shadow invalid */ diff --git a/packages/number-field/src/vaadin-number-field.js b/packages/number-field/src/vaadin-number-field.js index 58938d7fa66..4785a39c00d 100644 --- a/packages/number-field/src/vaadin-number-field.js +++ b/packages/number-field/src/vaadin-number-field.js @@ -122,9 +122,9 @@ export class NumberField extends NumberFieldMixin(ThemableMixin(ElementMixin(Pol
- - + + `; } } diff --git a/packages/number-field/test/dom/__snapshots__/number-field.test.snap.js b/packages/number-field/test/dom/__snapshots__/number-field.test.snap.js index f8c3cb36560..69d54c64b26 100644 --- a/packages/number-field/test/dom/__snapshots__/number-field.test.snap.js +++ b/packages/number-field/test/dom/__snapshots__/number-field.test.snap.js @@ -224,9 +224,9 @@ snapshots["vaadin-number-field shadow default"] = + + - - `; /* end snapshot vaadin-number-field shadow default */ @@ -282,9 +282,9 @@ snapshots["vaadin-number-field shadow step-buttons-visible"] = + + - - `; /* end snapshot vaadin-number-field shadow step-buttons-visible */ @@ -345,9 +345,9 @@ snapshots["vaadin-number-field shadow disabled"] = + + - - `; /* end snapshot vaadin-number-field shadow disabled */ @@ -408,9 +408,9 @@ snapshots["vaadin-number-field shadow readonly"] = + + - - `; /* end snapshot vaadin-number-field shadow readonly */ @@ -471,9 +471,9 @@ snapshots["vaadin-number-field shadow invalid"] = + + - - `; /* end snapshot vaadin-number-field shadow invalid */ @@ -534,9 +534,9 @@ snapshots["vaadin-number-field shadow theme"] = + + - - `; /* end snapshot vaadin-number-field shadow theme */ diff --git a/packages/password-field/test/dom/__snapshots__/password-field.test.snap.js b/packages/password-field/test/dom/__snapshots__/password-field.test.snap.js index dfd650471b6..77f4a94a282 100644 --- a/packages/password-field/test/dom/__snapshots__/password-field.test.snap.js +++ b/packages/password-field/test/dom/__snapshots__/password-field.test.snap.js @@ -156,9 +156,9 @@ snapshots["vaadin-password-field shadow default"] = + + - - `; /* end snapshot vaadin-password-field shadow default */ @@ -212,9 +212,9 @@ snapshots["vaadin-password-field shadow disabled"] = + + - - `; /* end snapshot vaadin-password-field shadow disabled */ @@ -268,9 +268,9 @@ snapshots["vaadin-password-field shadow readonly"] = + + - - `; /* end snapshot vaadin-password-field shadow readonly */ @@ -324,9 +324,9 @@ snapshots["vaadin-password-field shadow invalid"] = + + - - `; /* end snapshot vaadin-password-field shadow invalid */ @@ -380,9 +380,9 @@ snapshots["vaadin-password-field shadow theme"] = + + - - `; /* end snapshot vaadin-password-field shadow theme */ diff --git a/packages/text-area/src/vaadin-text-area.js b/packages/text-area/src/vaadin-text-area.js index dfe57251b3a..20de3b16431 100644 --- a/packages/text-area/src/vaadin-text-area.js +++ b/packages/text-area/src/vaadin-text-area.js @@ -95,9 +95,9 @@ export class TextArea extends TextAreaMixin(ThemableMixin(ElementMixin(PolymerEl
- - + + `; } diff --git a/packages/text-area/test/dom/__snapshots__/text-area.test.snap.js b/packages/text-area/test/dom/__snapshots__/text-area.test.snap.js index abbb59361d8..89767dbe18e 100644 --- a/packages/text-area/test/dom/__snapshots__/text-area.test.snap.js +++ b/packages/text-area/test/dom/__snapshots__/text-area.test.snap.js @@ -126,9 +126,9 @@ snapshots["vaadin-text-area shadow default"] = + + - - `; /* end snapshot vaadin-text-area shadow default */ @@ -175,9 +175,9 @@ snapshots["vaadin-text-area shadow disabled"] = + + - - `; /* end snapshot vaadin-text-area shadow disabled */ @@ -224,9 +224,9 @@ snapshots["vaadin-text-area shadow readonly"] = + + - - `; /* end snapshot vaadin-text-area shadow readonly */ @@ -273,9 +273,9 @@ snapshots["vaadin-text-area shadow invalid"] = + + - - `; /* end snapshot vaadin-text-area shadow invalid */ @@ -322,9 +322,9 @@ snapshots["vaadin-text-area shadow theme"] = + + - - `; /* end snapshot vaadin-text-area shadow theme */ diff --git a/packages/text-field/src/vaadin-text-field.js b/packages/text-field/src/vaadin-text-field.js index b6e8e0912a5..32d7592fb11 100644 --- a/packages/text-field/src/vaadin-text-field.js +++ b/packages/text-field/src/vaadin-text-field.js @@ -116,8 +116,9 @@ export class TextField extends TextFieldMixin(ThemableMixin(ElementMixin(Polymer
+ + - `; } diff --git a/packages/text-field/test/dom/__snapshots__/text-field.test.snap.js b/packages/text-field/test/dom/__snapshots__/text-field.test.snap.js index 43dbbc380bb..4534d43da76 100644 --- a/packages/text-field/test/dom/__snapshots__/text-field.test.snap.js +++ b/packages/text-field/test/dom/__snapshots__/text-field.test.snap.js @@ -148,9 +148,9 @@ snapshots["vaadin-text-field shadow default"] = + + - - `; /* end snapshot vaadin-text-field shadow default */ @@ -197,9 +197,9 @@ snapshots["vaadin-text-field shadow disabled"] = + + - - `; /* end snapshot vaadin-text-field shadow disabled */ @@ -246,9 +246,9 @@ snapshots["vaadin-text-field shadow readonly"] = + + - - `; /* end snapshot vaadin-text-field shadow readonly */ @@ -295,9 +295,9 @@ snapshots["vaadin-text-field shadow invalid"] = + + - - `; /* end snapshot vaadin-text-field shadow invalid */ @@ -344,9 +344,9 @@ snapshots["vaadin-text-field shadow theme"] = + + - - `; /* end snapshot vaadin-text-field shadow theme */ diff --git a/packages/time-picker/src/vaadin-time-picker.js b/packages/time-picker/src/vaadin-time-picker.js index f2f949e74d3..1f9bcbef2dc 100644 --- a/packages/time-picker/src/vaadin-time-picker.js +++ b/packages/time-picker/src/vaadin-time-picker.js @@ -158,8 +158,9 @@ class TimePicker extends TimePickerMixin(ThemableMixin(ElementMixin(PolymerEleme
+ + - `; } } diff --git a/packages/time-picker/test/dom/__snapshots__/time-picker.test.snap.js b/packages/time-picker/test/dom/__snapshots__/time-picker.test.snap.js index 0a7b95ee5b8..1288cbcedd8 100644 --- a/packages/time-picker/test/dom/__snapshots__/time-picker.test.snap.js +++ b/packages/time-picker/test/dom/__snapshots__/time-picker.test.snap.js @@ -962,9 +962,9 @@ snapshots["vaadin-time-picker shadow default"] = + + - - `; /* end snapshot vaadin-time-picker shadow default */ @@ -1021,9 +1021,9 @@ snapshots["vaadin-time-picker shadow disabled"] = + + - - `; /* end snapshot vaadin-time-picker shadow disabled */ @@ -1079,9 +1079,9 @@ snapshots["vaadin-time-picker shadow readonly"] = + + - - `; /* end snapshot vaadin-time-picker shadow readonly */ @@ -1136,9 +1136,9 @@ snapshots["vaadin-time-picker shadow invalid"] = + + - - `; /* end snapshot vaadin-time-picker shadow invalid */ @@ -1194,9 +1194,9 @@ snapshots["vaadin-time-picker shadow theme"] = + + - - `; /* end snapshot vaadin-time-picker shadow theme */ From 077f801ca99ad11d11e9e44b44c3a01cf6c79f91 Mon Sep 17 00:00:00 2001 From: Diego Cardoso Date: Tue, 4 Nov 2025 11:04:10 +0100 Subject: [PATCH 2/2] update lit components --- packages/combo-box/src/vaadin-lit-combo-box.js | 4 ++-- packages/date-picker/src/vaadin-lit-date-picker.js | 4 ++-- .../src/vaadin-lit-multi-select-combo-box.js | 4 ++-- packages/number-field/src/vaadin-lit-number-field.js | 4 ++-- packages/text-area/src/vaadin-lit-text-area.js | 4 ++-- packages/text-field/src/vaadin-lit-text-field.js | 4 ++-- packages/time-picker/src/vaadin-lit-time-picker.js | 4 ++-- 7 files changed, 14 insertions(+), 14 deletions(-) diff --git a/packages/combo-box/src/vaadin-lit-combo-box.js b/packages/combo-box/src/vaadin-lit-combo-box.js index 259e91a568e..ddc23d07734 100644 --- a/packages/combo-box/src/vaadin-lit-combo-box.js +++ b/packages/combo-box/src/vaadin-lit-combo-box.js @@ -98,6 +98,8 @@ class ComboBox extends ComboBoxDataProviderMixin(
+ + - - `; } diff --git a/packages/date-picker/src/vaadin-lit-date-picker.js b/packages/date-picker/src/vaadin-lit-date-picker.js index b1568f1b9e2..16b4abf6d6c 100644 --- a/packages/date-picker/src/vaadin-lit-date-picker.js +++ b/packages/date-picker/src/vaadin-lit-date-picker.js @@ -86,6 +86,8 @@ class DatePicker extends DatePickerMixin(InputControlMixin(ThemableMixin(Element
+ + - - `; } diff --git a/packages/multi-select-combo-box/src/vaadin-lit-multi-select-combo-box.js b/packages/multi-select-combo-box/src/vaadin-lit-multi-select-combo-box.js index 0c45ba1c7ef..989a0b9e0e9 100644 --- a/packages/multi-select-combo-box/src/vaadin-lit-multi-select-combo-box.js +++ b/packages/multi-select-combo-box/src/vaadin-lit-multi-select-combo-box.js @@ -109,9 +109,9 @@ class MultiSelectComboBox extends MultiSelectComboBoxMixin(ThemableMixin(Element
- - + + `; } diff --git a/packages/number-field/src/vaadin-lit-number-field.js b/packages/number-field/src/vaadin-lit-number-field.js index f5aa4155c4b..2d0d9b84ff9 100644 --- a/packages/number-field/src/vaadin-lit-number-field.js +++ b/packages/number-field/src/vaadin-lit-number-field.js @@ -79,9 +79,9 @@ class NumberField extends NumberFieldMixin(ThemableMixin(ElementMixin(PolylitMix
- - + + `; } } diff --git a/packages/text-area/src/vaadin-lit-text-area.js b/packages/text-area/src/vaadin-lit-text-area.js index 9c30174683f..1a7ab5e3b5d 100644 --- a/packages/text-area/src/vaadin-lit-text-area.js +++ b/packages/text-area/src/vaadin-lit-text-area.js @@ -63,9 +63,9 @@ export class TextArea extends TextAreaMixin(ThemableMixin(ElementMixin(PolylitMi
- - + + `; } diff --git a/packages/text-field/src/vaadin-lit-text-field.js b/packages/text-field/src/vaadin-lit-text-field.js index c3df7dba145..5410fc5a2fd 100644 --- a/packages/text-field/src/vaadin-lit-text-field.js +++ b/packages/text-field/src/vaadin-lit-text-field.js @@ -60,9 +60,9 @@ export class TextField extends TextFieldMixin(ThemableMixin(ElementMixin(Polylit
- - + + `; } diff --git a/packages/time-picker/src/vaadin-lit-time-picker.js b/packages/time-picker/src/vaadin-lit-time-picker.js index 33bf891d479..03dd9537a27 100644 --- a/packages/time-picker/src/vaadin-lit-time-picker.js +++ b/packages/time-picker/src/vaadin-lit-time-picker.js @@ -95,9 +95,9 @@ class TimePicker extends TimePickerMixin(ThemableMixin(ElementMixin(PolylitMixin
- - + + `; }