Report the full match for the OAuth 2.0 rule

The self-match reported in issue #41 ("Use 'OAuth 2.0' instead of
'OAuth 2.0'") was fixed upstream in fec6b34, but that fix left the
alternatives shortest-first. Regex alternation takes the first branch
that matches, so "OAuth 2" matched only the bare "OAuth" alternative and
the alert read "Use 'OAuth 2.0' instead of 'OAuth'" — applying which
gives "OAuth 2.0 2".

Ordering the alternatives longest-first makes each variant report the
span it actually means. The inline (?i) is dropped as redundant: the rule
sets ignorecase.

Fixtures now cover OAuth 2.0 as a negative and OAuth 2, OAuth2,
OAuth2.0, and Oauth as positives.

Author: jdkato

Google/WordListCase.yml

@@ -15,7 +15,10 @@ swap:
   "(?:e-mail|Email|E-mail)": email
   "(?:file ?path|path ?name)": path
   "(?:kill|terminate|abort)": stop|exit|cancel|end
-  "(?i)\\bOauth\\b(?! 2\\.0)|\\bOauth2\\.0\\b|\\bOAuth ?2\\b(?!\\.0)": OAuth 2.0
+  # Longest form first: with the shortest alternative leading, 'OAuth 2' matched
+  # only 'OAuth', so applying the suggestion produced 'OAuth 2.0 2'. The rule is
+  # already case-insensitive, so the inline (?i) is redundant. See issue #41.
+  '\bOauth2\.0\b|\bOAuth ?2\b(?!\.0)|\bOauth\b(?! ?2)': OAuth 2.0
   "(?:ok|Okay)": OK|okay
   "(?:WiFi|wifi)": Wi-Fi
   '[\.]+apk': APK

fixtures/Terms/test.md

@@ -31,3 +31,7 @@ Look at the section above.
 I used my cell phone to make the call.
 
 Please check back later.
+
+We support OAuth 2.0 for authentication.
+
+We support OAuth 2, OAuth2, OAuth2.0, and Oauth.

testdata/Terms.ct

@@ -14,3 +14,7 @@ test.md:29:21:Google.WordListCase:Use 'preceding' instead of 'above'.
 test.md:31:1:Google.FirstPerson:Avoid first-person pronouns such as 'I '.
 test.md:31:8:Google.FirstPerson:Avoid first-person pronouns such as 'my'.
 test.md:31:11:Google.WordListCase:Use 'phone' or 'mobile phone' instead of 'cell phone'.
+test.md:37:12:Google.WordListCase:Use 'OAuth 2.0' instead of 'OAuth 2'.
+test.md:37:21:Google.WordListCase:Use 'OAuth 2.0' instead of 'OAuth2'.
+test.md:37:29:Google.WordListCase:Use 'OAuth 2.0' instead of 'OAuth2.0'.
+test.md:37:43:Google.WordListCase:Use 'OAuth 2.0' instead of 'Oauth'.