Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/topics/functions-intro.md has bad formatting, improper framing #104

Open
stockholmux opened this issue May 27, 2024 · 1 comment
Open

Comments

@stockholmux
Copy link
Member

stockholmux commented May 27, 2024

In pre-publishing review (#91) I found the following issues on functions-intro.md

!KEYS and ARGV Lua APIs

Using the odd bang formatting which is invalid Valkey syntax.

Redis OSS v7.0 introduces Valkey Functions

Redis didn't introduce Valkey Functions :)

There are plans to support additional engines in the future.

Is this still true? It's probably best to remove forward looking statements in the documentation if there isn't some way to track it with an issue or roadmap item.

@stockholmux stockholmux changed the title /topics/functions-intro.md has outdated information, bad formatting, improper framing /topics/functions-intro.md has bad formatting, improper framing May 27, 2024
@madolson
Copy link
Member

Is this still true? It's probably best to remove forward looking statements in the documentation if there isn't some way to track it with an issue or roadmap item.

No, this was Redis ltd. wording because they wanted to add javascript support to the main engine. We should drop this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants