RuntimeError in valkey.asyncio.cluster.NodesManager.initialize()

[jakob-keller]

I've noticed RuntimeError: dictionary changed size during iteration being raised in valkey.asyncio.cluster.NodesManager.initialize()

valkey-py/valkey/asyncio/cluster.py

Line 1291 in ca5c7c5

for startup_node in self.startup_nodes.values():

I believe this can be triggered during error handling in:

valkey-py/valkey/asyncio/cluster.py

Line 816 in ca5c7c5

self.nodes_manager.startup_nodes.pop(target_node.name, None)

A quick fix might be to wrap self.startup_nodes.values() in a tuple.

Should I prepare a PR?

[mkmkme]

Hey @jakob-keller !

Thanks for your contribution! I'll look into this issue as soon as I can. If you have a vision of how to fix this, please feel free to create a PR! I'll happily review it :)

[jakob-keller]

If you have a vision of how to fix this, please feel free to create a PR! I'll happily review it :)

The fix is trivial: #184