Support Valkey image:latest and Redis:latest for test #258
Conversation
zunda-pixel
force-pushed
the
test-multi-valkey-version
branch
from
1e62f6d to
afc4a44
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
=======================================
Coverage ? 40.95%
=======================================
Files ? 97
Lines ? 12296
Branches ? 0
=======================================
Hits ? 5036
Misses ? 7260
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I don't think there is any need for multiple valkey images. There isn't enough of a difference between versions. But adding the latest redis might be useful |
|
Sorry for the misunderstanding. I’ve added Valkey v9. Should I delete v8? |
|
Maybe use images |
zunda-pixel
force-pushed
the
test-multi-valkey-version
branch
4 times, most recently
from
fc82827 to
1c02d2c
Compare
|
disable these test, CI is succeeded |
|
Interesting FUNCTION LIST and SCRIPT LIST fail. |
zunda-pixel
changed the title
| redis.register_function('valkey_swift_test_set', test_set) | ||
| redis.register_function('valkey_swift_test_get', test_get) |
There was a problem hiding this comment.
rename to fix testFUNCTIONLIST() for Redis
|
|
||
| @available(valkeySwift 1.0, *) | ||
| @Test | ||
| @Test(.enabled(if: Self.isValkey)) |
There was a problem hiding this comment.
testSCRIPTfunctions() is enabled for Valkey not Redis
Redis has no SCRIPT SHOW
Signed-off-by: zunda <[email protected]>
zunda-pixel
force-pushed
the
test-multi-valkey-version
branch
from
4ab03be to
5902dbd
Compare
Signed-off-by: yazawa hiroki <[email protected]> Signed-off-by: zunda <[email protected]>
Signed-off-by: zunda <[email protected]>
remove space Signed-off-by: zunda <[email protected]>
zunda-pixel
force-pushed
the
test-multi-valkey-version
branch
from
5902dbd to
7404c92
Compare
3 participants
Add Valkey image v9.0 for testAdd Valkey image:latest(v9.0)
Add Redis image:latest(v8.4)
disable testSCRIPTfunctions() for Redis