Skip to content

[BUG] make test should detect ipv6 support #2643

@Redoubts

Description

@Redoubts

If I download source and build, the log will happily report Hint: It's a good idea to run 'make test' ;)

but when I do make test, I'll see

[exception]: Executing test client: couldn't open socket: host is unreachable.
couldn't open socket: host is unreachable
    while executing
"socket $server $port"
    (procedure "valkey" line 7)
    invoked from within
"valkey ::1 [srv 0 port] 0 $::tls"
    ("uplevel" body line 2)
    invoked from within
"uplevel 1 $code"
    (procedure "test" line 62)
    invoked from within
"test {CLIENT LIST with IPv6 filter} {
            set c [valkey ::1 [srv 0 port] 0 $::tls]
            $c client setname "client-ipv6"

            se..."
    ("uplevel" body line 2)
    invoked from within
"uplevel 1 $code "
    (procedure "start_server" line 2)
    invoked from within
"start_server {tags {"ipv6"} overrides {bind {127.0.0.1 ::1}}} {
        test {CLIENT LIST with IPv6 filter} {
            set c [valkey ::1 [srv 0 por..."
    ("uplevel" body line 228)
    invoked from within
"uplevel 1 $code "
    (procedure "start_server" line 2)
    invoked from within
"start_server {tags {"introspection"}} {
    test "PING" {
        assert_equal {PONG} [r ping]
        assert_equal {valkey} [r ping valkey]
        a..."
    (file "tests/unit/introspection.tcl" line 1)
    invoked from within
"source $path"
    (procedure "execute_test_file" line 4)
    invoked from within
"execute_test_file $data"
    (procedure "test_client_main" line 10)
    invoked from within
"test_client_main $::test_server_port "
Killing still running Valkey server ...
make[1]: *** [Makefile:591: test] Error 1

which is unfortunate. This is because my hosts don't have ipv6 enabled. While I can dig around and find an invocation that will work (./runtest --tags -ipv6), it would be nice if this were automagic. An end user just wants to care that their build is valid, without too much thought.

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions