Skip to content

Commit 8159dcc

Browse files
committed
extmod/modos: Include os.sep entry if MICROPY_VFS is enabled.
This simplifies configuration by removing the `MICROPY_PY_OS_SEP` option and instead including `os.sep` if `MICROPY_VFS` is enabled. That matches the configuration of all existing ports that enabled `os.sep` (they also had `MICROPY_VFS` enabled), and brings consistency to other ports. Fixes issue micropython#15116. Signed-off-by: Damien George <[email protected]>
1 parent 5f3ecc2 commit 8159dcc

File tree

6 files changed

+1
-8
lines changed

6 files changed

+1
-8
lines changed

extmod/modos.c

+1-3
Original file line numberDiff line numberDiff line change
@@ -153,9 +153,6 @@ static const mp_rom_map_elem_t os_module_globals_table[] = {
153153
{ MP_ROM_QSTR(MP_QSTR_putenv), MP_ROM_PTR(&mp_os_putenv_obj) },
154154
{ MP_ROM_QSTR(MP_QSTR_unsetenv), MP_ROM_PTR(&mp_os_unsetenv_obj) },
155155
#endif
156-
#if MICROPY_PY_OS_SEP
157-
{ MP_ROM_QSTR(MP_QSTR_sep), MP_ROM_QSTR(MP_QSTR__slash_) },
158-
#endif
159156
#if MICROPY_PY_OS_SYNC
160157
{ MP_ROM_QSTR(MP_QSTR_sync), MP_ROM_PTR(&mp_os_sync_obj) },
161158
#endif
@@ -170,6 +167,7 @@ static const mp_rom_map_elem_t os_module_globals_table[] = {
170167
#endif
171168

172169
#if MICROPY_VFS
170+
{ MP_ROM_QSTR(MP_QSTR_sep), MP_ROM_QSTR(MP_QSTR__slash_) },
173171
{ MP_ROM_QSTR(MP_QSTR_chdir), MP_ROM_PTR(&mp_vfs_chdir_obj) },
174172
{ MP_ROM_QSTR(MP_QSTR_getcwd), MP_ROM_PTR(&mp_vfs_getcwd_obj) },
175173
{ MP_ROM_QSTR(MP_QSTR_listdir), MP_ROM_PTR(&mp_vfs_listdir_obj) },

ports/nrf/mpconfigport.h

-1
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,6 @@
151151
#define MICROPY_PY_OS_INCLUDEFILE "ports/nrf/modules/os/modos.c"
152152
#define MICROPY_PY_OS_DUPTERM (1)
153153
#define MICROPY_PY_OS_DUPTERM_STREAM_DETACHED_ATTACHED (1)
154-
#define MICROPY_PY_OS_SEP (1)
155154
#define MICROPY_PY_OS_SYNC (MICROPY_VFS)
156155
#define MICROPY_PY_OS_UNAME (1)
157156
#define MICROPY_PY_OS_URANDOM (MICROPY_HW_ENABLE_RNG)

ports/renesas-ra/mpconfigport.h

-1
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,6 @@
120120
#define MICROPY_PY_OS_DUPTERM (3)
121121
#define MICROPY_PY_OS_DUPTERM_BUILTIN_STREAM (1)
122122
#define MICROPY_PY_OS_DUPTERM_STREAM_DETACHED_ATTACHED (1)
123-
#define MICROPY_PY_OS_SEP (1)
124123
#define MICROPY_PY_OS_SYNC (1)
125124
#define MICROPY_PY_OS_UNAME (1)
126125
#define MICROPY_PY_OS_URANDOM (MICROPY_HW_ENABLE_RNG)

ports/stm32/mpconfigport.h

-1
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,6 @@
9999
#define MICROPY_PY_OS_DUPTERM (3)
100100
#define MICROPY_PY_OS_DUPTERM_BUILTIN_STREAM (1)
101101
#define MICROPY_PY_OS_DUPTERM_STREAM_DETACHED_ATTACHED (1)
102-
#define MICROPY_PY_OS_SEP (1)
103102
#define MICROPY_PY_OS_SYNC (1)
104103
#define MICROPY_PY_OS_UNAME (1)
105104
#define MICROPY_PY_OS_URANDOM (MICROPY_HW_ENABLE_RNG)

ports/unix/variants/mpconfigvariant_common.h

-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@
9595
#define MICROPY_PY_OS_INCLUDEFILE "ports/unix/modos.c"
9696
#define MICROPY_PY_OS_ERRNO (1)
9797
#define MICROPY_PY_OS_GETENV_PUTENV_UNSETENV (1)
98-
#define MICROPY_PY_OS_SEP (1)
9998
#define MICROPY_PY_OS_SYSTEM (1)
10099
#define MICROPY_PY_OS_URANDOM (1)
101100

ports/windows/mpconfigport.h

-1
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,6 @@
136136
#define MICROPY_PY_OS_INCLUDEFILE "ports/unix/modos.c"
137137
#define MICROPY_PY_OS_ERRNO (1)
138138
#define MICROPY_PY_OS_GETENV_PUTENV_UNSETENV (1)
139-
#define MICROPY_PY_OS_SEP (1)
140139
#define MICROPY_PY_OS_STATVFS (0)
141140
#define MICROPY_PY_OS_SYSTEM (1)
142141
#define MICROPY_PY_OS_URANDOM (1)

0 commit comments

Comments
 (0)