fix: update clang-tidy checks for potential issues in control flow passes

Author: vasie1337

.clang-tidy

@@ -2,6 +2,8 @@ Checks: >
   -*,
   bugprone-*,
   clang-analyzer-*,
+  -clang-analyzer-security.ArrayBound,
+  -clang-analyzer-optin.core.EnumCastOutOfRange,
   modernize-*,
   performance-*,
   readability-*,

passes/src/PassPlugin.cpp

@@ -6,17 +6,24 @@ using namespace llvm;
 using namespace obfuscator;
 
 static BasicBlockFission parseBBFissionParams(StringRef Params) {
-    unsigned Junk = 2, Max = 64, Split = 1;
+    unsigned Junk = 2;
+    unsigned Max = 64;
+    unsigned Split = 1;
     while (!Params.empty()) {
-        StringRef Token;
-        std::tie(Token, Params) = Params.split(';');
-        StringRef K, V;
-        std::tie(K, V) = Token.split('=');
-        if (K == "junk")       V.getAsInteger(10, Junk);
-        else if (K == "max")   V.getAsInteger(10, Max);
-        else if (K == "split") V.getAsInteger(10, Split);
+        auto [Token, Rest] = Params.split(';');
+        Params = Rest;
+        auto [K, V] = Token.split('=');
+        if (K == "junk") {
+            V.getAsInteger(10, Junk);
+        } else if (K == "max") {
+            V.getAsInteger(10, Max);
+        } else if (K == "split") {
+            V.getAsInteger(10, Split);
+        }
+    }
+    if (Split == 0) {
+        Split = 1;
     }
-    if (Split == 0) Split = 1;
     return {Junk, Max, Split};
 }
 
@@ -54,8 +61,9 @@ llvm::PassPluginLibraryInfo getObfuscatorPluginInfo() {
                 }
                 if (Name == "bbfission" || Name.starts_with("bbfission<")) {
                     StringRef Params;
-                    if (Name.starts_with("bbfission<") && Name.ends_with(">"))
+                    if (Name.starts_with("bbfission<") && Name.ends_with(">")) {
                         Params = Name.slice(10, Name.size() - 1);
+                    }
                     FPM.addPass(parseBBFissionParams(Params));
                     return true;
                 }