From bb46b4888fae2df8dcb6d017a438cc1d2e4682be Mon Sep 17 00:00:00 2001 From: Bharat khairnar Date: Mon, 19 Jun 2023 16:29:53 +0530 Subject: [PATCH] Removed the unnecessary code and use array_filter instead of foreach. Code refactoring done --- src/helpers.php | 30 +++++++++--------------------- 1 file changed, 9 insertions(+), 21 deletions(-) diff --git a/src/helpers.php b/src/helpers.php index 52c34d0..cff5633 100644 --- a/src/helpers.php +++ b/src/helpers.php @@ -10,42 +10,30 @@ function refiner($request) : mixed { try { - if (is_array($request)) { - return $request; - } - - $requestData = $request->all(); + if (!is_array($request)) { + $requestData = $request->all(); - if ($requestData) { foreach ($requestData as $key => $value) { - $filterString = []; - $requestedString = []; - if (!is_array($value)) { $requestedString = strtolower($value); $requestedString = explode(' ', $requestedString); - } - $detectWords = config('refiner'); - $detectWords = array_flip($detectWords); + $detectWords = array_flip(config('refiner')); - foreach ($requestedString as $words) { - $filterWords = rtrim($words, '.'); + $filterString = array_filter($requestedString, function ($word) use ($detectWords) { + $filterWords = rtrim($word, '.'); + return !isset($detectWords[$filterWords]); + }); - if (!isset($detectWords[$filterWords])) { - $filterString[] = $words; - } + $filterString = implode(' ', $filterString); + $request = $request->merge([$key => $filterString]); } - - $filterString = implode(' ', $filterString); - $request = $request->merge([$key => $filterString]); } } return $request; } catch (Exception $ex) { Log::error($ex->getMessage()); - return collect([]); } }