Skip to content

Commit 6eb55d0

Browse files
committed
Fix failing tests.
1 parent 8c6ab20 commit 6eb55d0

File tree

3 files changed

+34
-21
lines changed

3 files changed

+34
-21
lines changed

AuthenticodeLintTests/Rules/PublisherInformationPresentRuleTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public void ShouldFailWhenNoPublisherInformation()
2121

2222
var result = rule.Validate(signature, logger, Configuration);
2323
Assert.Equal(RuleResult.Fail, result);
24-
Assert.Collection(logger.Messages, s => s.EndsWith("Signature does not have an accompanying description."), s => s.EndsWith("Signature does not have an accompanying URL."));
24+
Assert.Collection(logger.Messages, s => s.EndsWith("Signature does not have any publisher information."));
2525
}
2626

2727
[Fact]

AuthenticodeLintTests/Rules/Sha1PrimarySignatureRuleTests.cs

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -47,25 +47,5 @@ public void ShouldPassOnSha1Algorithm()
4747
Assert.Equal(RuleResult.Pass, result);
4848
Assert.Empty(logger.Messages);
4949
}
50-
51-
52-
[Fact]
53-
public void ShouldFailOnMultiplePrimarySignatures()
54-
{
55-
var signature1 = new FakeSignature
56-
{
57-
DigestAlgorithm = new Oid(KnownOids.SHA1)
58-
};
59-
var signature2 = new FakeSignature
60-
{
61-
DigestAlgorithm = new Oid(KnownOids.SHA256)
62-
};
63-
var check = new Sha1PrimarySignatureRule();
64-
var logger = new MemorySignatureLogger();
65-
var result = check.Validate(new List<ICmsSignature> { signature1, signature2 }, logger, Configuration);
66-
Assert.Equal(RuleResult.Fail, result);
67-
Assert.Contains("Multiple primary signatures exist.", logger.Messages);
68-
69-
}
7050
}
7151
}
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
using AuthenticodeExaminer;
2+
using AuthenticodeLint;
3+
using AuthenticodeLint.Rules;
4+
using System.Collections.Generic;
5+
using System.Security.Cryptography;
6+
using Xunit;
7+
8+
namespace AuthenticodeLintTests.Rules
9+
{
10+
public class SinglePrimarySignatureRuleTest
11+
{
12+
private static CheckConfiguration Configuration => new CheckConfiguration(new List<string>(), null, false, new HashSet<int>(), false, RevocationChecking.None, null, RuleSet.Compat);
13+
14+
[Fact]
15+
public void ShouldFailOnMultiplePrimarySignatures()
16+
{
17+
var signature1 = new FakeSignature
18+
{
19+
DigestAlgorithm = new Oid(KnownOids.SHA1)
20+
};
21+
var signature2 = new FakeSignature
22+
{
23+
DigestAlgorithm = new Oid(KnownOids.SHA256)
24+
};
25+
var check = new SinglePrimarySignatureRule();
26+
var logger = new MemorySignatureLogger();
27+
var result = check.Validate(new List<ICmsSignature> { signature1, signature2 }, logger, Configuration);
28+
Assert.Equal(RuleResult.Fail, result);
29+
Assert.Contains("Multiple primary signatures exist.", logger.Messages);
30+
31+
}
32+
}
33+
}

0 commit comments

Comments
 (0)