Small fixes

Author: Nil Portugues Caldero

.gitignore

@@ -1,5 +1,4 @@
 bin/
-.idea/
 vendor/
 composer.lock
 build/

src/Server/Actions/Traits/RequestTrait.php

@@ -12,7 +12,6 @@
 use NilPortugues\Api\JsonApi\Http\Request\Parameters\Fields;
 use NilPortugues\Api\JsonApi\Http\Request\Parameters\Included;
 use NilPortugues\Api\JsonApi\JsonApiSerializer;
-use NilPortugues\Api\JsonApi\Server\Errors\Error;
 use NilPortugues\Api\JsonApi\Server\Errors\InvalidParameterError;
 use NilPortugues\Api\JsonApi\Server\Errors\InvalidParameterMemberError;
 use NilPortugues\Api\Mapping\Mapping;
@@ -23,12 +22,12 @@
 trait RequestTrait
 {
     /**
-     * @var Error[]
+     * @var \NilPortugues\Api\JsonApi\Server\Errors\Error[]
      */
     protected $queryParamErrorBag = [];
 
     /**
-     * @return Error[]
+     * @return \NilPortugues\Api\JsonApi\Server\Errors\Error[]
      */
     protected function getQueryParamsErrors()
     {
@@ -42,7 +41,7 @@ protected function getQueryParamsErrors()
      *
      * @return bool
      */
-    protected function hasValidQueryParams($serializer, Fields $fields, Included $included)
+    protected function hasValidQueryParams(JsonApiSerializer $serializer, Fields $fields, Included $included)
     {
         $this->validateFieldsQueryParams($serializer, $fields, 'Fields');
         $this->validateIncludeQueryParamsTypes($serializer, $included, 'Include');
@@ -55,7 +54,7 @@ protected function hasValidQueryParams($serializer, Fields $fields, Included $in
      * @param Fields            $fields
      * @param string            $paramName
      */
-    protected function validateFieldsQueryParams($serializer, Fields $fields, $paramName)
+    protected function validateFieldsQueryParams(JsonApiSerializer $serializer, Fields $fields, $paramName)
     {
         if (false === $fields->isEmpty()) {
             $validateFields = $fields->types();
@@ -121,7 +120,7 @@ protected function addInvalidParameterErrorsToErrorBag($paramName, array &$valid
      * @param Included          $included
      * @param string            $paramName
      */
-    protected function validateIncludeQueryParamsTypes($serializer, Included $included, $paramName)
+    protected function validateIncludeQueryParamsTypes(JsonApiSerializer $serializer, Included $included, $paramName)
     {
         if (false === $included->isEmpty()) {
             $validateFields = array_keys($included->get());

src/Server/Data/DataObject.php

@@ -81,7 +81,7 @@ public static function assertPut($data, JsonApiSerializer $serializer, $classNam
      *
      * @return array
      */
-    protected static function missingCreationAttributes(array $data, $serializer)
+    protected static function missingCreationAttributes(array $data, JsonApiSerializer $serializer)
     {
         $inputAttributes = array_keys($data[JsonApiTransformer::ATTRIBUTES_KEY]);
 

src/Server/Query/QueryObject.php

@@ -108,14 +108,14 @@ protected static function validateIncludeParams(
         $transformer = $serializer->getTransformer();
 
         foreach ($included->get() as $resource => $data) {
-            if (null == $transformer->getMappingByAlias($resource)) {
-                $errorBag[] = new InvalidParameterError($resource, strtolower($paramName));
+            if (null === $transformer->getMappingByAlias($resource)) {
+                $errorBag->offsetSet(null, new InvalidParameterError($resource, strtolower($paramName)));
                 continue;
             }
 
             if (is_array($data)) {
                 foreach ($data as $subResource) {
-                    if (null == $transformer->getMappingByAlias($subResource)) {
+                    if (null === $transformer->getMappingByAlias($subResource)) {
                         $errorBag->offsetSet(null, new InvalidParameterError($subResource, strtolower($paramName)));
                     }
                 }