Skip to content

Commit 648181c

Browse files
committed
naming and comment
1 parent 72a4b1e commit 648181c

File tree

3 files changed

+7
-14
lines changed

3 files changed

+7
-14
lines changed

turbopack/crates/turbopack-core/src/chunk/availability_info.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ bitfield! {
1010
#[derive(Clone, Copy, Default, TaskInput, TraceRawVcs, NonLocalValue, Serialize, Deserialize, PartialEq, Eq, Hash)]
1111
pub struct AvailabilityFlags(u8);
1212
impl Debug;
13-
pub is_in_of_async_module, set_is_in_of_async_module: 0;
13+
pub is_in_async_module, set_is_in_async_module: 0;
1414
}
1515

1616
#[derive(
@@ -65,15 +65,15 @@ impl AvailabilityInfo {
6565

6666
pub fn in_async_module(self) -> Self {
6767
let mut flags = self.flags;
68-
flags.set_is_in_of_async_module(true);
68+
flags.set_is_in_async_module(true);
6969
Self {
7070
flags,
7171
available_modules: self.available_modules,
7272
}
7373
}
7474

7575
pub fn is_in_async_module(&self) -> bool {
76-
self.flags.is_in_of_async_module()
76+
self.flags.is_in_async_module()
7777
}
7878

7979
pub async fn ident(&self) -> Result<Option<RcStr>> {

turbopack/crates/turbopack-core/src/chunk/chunk_group.rs

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -205,17 +205,6 @@ pub struct ChunkGroupContentOptions {
205205
}
206206

207207
/// Computes the content of a chunk group.
208-
///
209-
/// ### Parameters:
210-
/// - module_graph: the module graph
211-
/// - chunk_group_entries: the entries of the chunk group
212-
/// - availability_info: the availability info of the chunk group
213-
/// - can_split_async: indicates whether async modules can be split into separate chunks
214-
/// - update_availability_info: indicates whether to return a new availability info which includes
215-
/// all chunk items.
216-
/// - should_trace: indicates whether traced modules should be collected
217-
/// - should_merge_modules: indicates whether module merging is enabled
218-
/// - batching_config: the batching config to use
219208
pub async fn chunk_group_content(
220209
module_graph: Vc<ModuleGraph>,
221210
chunk_group_entries: impl IntoIterator<

turbopack/crates/turbopack-ecmascript/src/chunk/item.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,10 @@ pub trait EcmascriptChunkItem: ChunkItem + OutputAssetsReference {
228228
#[turbo_tasks::function]
229229
fn content(self: Vc<Self>) -> Vc<EcmascriptChunkItemContent>;
230230

231+
/// Fetches the content of the chunk item with async module info.
232+
/// When `estimated` is true, it's ok to provide an estimated content, since it's only used for
233+
/// compute the chunking. When `estimated` is true, this function should not invoke other
234+
/// chunking operations that would cause cycles.
231235
#[turbo_tasks::function]
232236
fn content_with_async_module_info(
233237
self: Vc<Self>,

0 commit comments

Comments
 (0)