.

Author: TooTallNate

packages/swc-plugin-workflow/transform/src/lib.rs

@@ -2292,13 +2292,6 @@ impl StepTransform {
                     ModuleItem::Stmt(Stmt::Decl(Decl::Var(var_decl))) => {
                         // Check if all variables in this declaration are unused
                         var_decl.decls.iter().all(|declarator| {
-                            // Don't remove if the initializer contains functions (which might have directives)
-                            if let Some(init) = &declarator.init {
-                                if self.contains_function_expr(init) {
-                                    return false;
-                                }
-                            }
-
                             match &declarator.name {
                                 Pat::Ident(binding) => {
                                     let name = binding.id.sym.to_string();
@@ -2393,20 +2386,6 @@ impl StepTransform {
         }
     }
 
-    // Helper to check if an expression contains a function expression or object with methods
-    fn contains_function_expr(&self, expr: &Expr) -> bool {
-        match expr {
-            Expr::Fn(_) | Expr::Arrow(_) => true,
-            Expr::Object(obj_lit) => {
-                // Check if object contains any method properties
-                obj_lit.props.iter().any(
-                    |prop| matches!(prop, PropOrSpread::Prop(p) if matches!(&**p, Prop::Method(_))),
-                )
-            }
-            _ => false,
-        }
-    }
-
     // Helper to check if all bindings in an array pattern are unused
     fn all_bindings_unused(
         &self,

packages/swc-plugin-workflow/transform/tests/errors/non-async-functions/output-client.js

@@ -9,13 +9,6 @@ export const syncWorkflow = ()=>{
     'use workflow';
     return 'test';
 };
-// Error: sync method with use step
-const obj = {
-    syncMethod () {
-        'use step';
-        return true;
-    }
-};
 // These are ok
 export async function validStep() {
     return 42;

packages/swc-plugin-workflow/transform/tests/errors/non-async-functions/output-workflow.js

@@ -9,13 +9,6 @@ export const syncWorkflow = ()=>{
     'use workflow';
     return 'test';
 };
-// Error: sync method with use step
-const obj = {
-    syncMethod () {
-        'use step';
-        return true;
-    }
-};
 // These are ok
 export var validStep = globalThis[Symbol.for("WORKFLOW_USE_STEP")]("step//input.js//validStep");
 export const validWorkflow = async ()=>{

packages/swc-plugin-workflow/transform/tests/fixture/module-level-step/output-client.js

@@ -1,7 +1,4 @@
 /**__internal_workflows{"steps":{"input.js":{"step":{"stepId":"step//input.js//step"},"stepArrow":{"stepId":"step//input.js//stepArrow"}}}}*/;
-const localArrow = async (input)=>{
-    return input.bar;
-};
 export async function step(input) {
     return input.foo;
 }

packages/swc-plugin-workflow/transform/tests/fixture/module-level-step/output-workflow.js

@@ -1,7 +1,4 @@
 /**__internal_workflows{"steps":{"input.js":{"step":{"stepId":"step//input.js//step"},"stepArrow":{"stepId":"step//input.js//stepArrow"}}}}*/;
 'use step';
-const localArrow = async (input)=>{
-    return input.bar;
-};
 export var step = globalThis[Symbol.for("WORKFLOW_USE_STEP")]("step//input.js//step");
 export const stepArrow = globalThis[Symbol.for("WORKFLOW_USE_STEP")]("step//input.js//stepArrow");

packages/swc-plugin-workflow/transform/tests/fixture/module-level-workflow/output-client.js

@@ -1,7 +1,4 @@
 /**__internal_workflows{"workflows":{"input.js":{"arrowWorkflow":{"workflowId":"workflow//input.js//arrowWorkflow"},"workflow":{"workflowId":"workflow//input.js//workflow"}}}}*/;
-const localArrow = async (input)=>{
-    return input.bar;
-};
 export async function workflow(input) {
     return input.foo;
 }

packages/swc-plugin-workflow/transform/tests/fixture/module-level-workflow/output-workflow.js

@@ -1,7 +1,4 @@
 /**__internal_workflows{"workflows":{"input.js":{"arrowWorkflow":{"workflowId":"workflow//input.js//arrowWorkflow"},"workflow":{"workflowId":"workflow//input.js//workflow"}}}}*/;
-const localArrow = async (input)=>{
-    return input.bar;
-};
 export async function workflow(input) {
     return input.foo;
 }

packages/swc-plugin-workflow/transform/tests/fixture/nested-step-with-closure/output-client.js

@@ -1,26 +1,4 @@
 /**__internal_workflows{"workflows":{"input.js":{"wflow":{"workflowId":"workflow//input.js//wflow"}}},"steps":{"input.js":{"_anonymousStep0":{"stepId":"step//input.js//_anonymousStep0"},"_anonymousStep1":{"stepId":"step//input.js//_anonymousStep1"},"f":{"stepId":"step//input.js//f"},"fn":{"stepId":"step//input.js//fn"}}}}*/;
-const arrowWrapperReturnArrowFunctionVar = (a, b, c)=>{
-    const fn = async ()=>{
-        return a + b + c;
-    };
-    return fn;
-};
-const arrowWrapperReturnNamedFunction = (a, b, c)=>{
-    return async function f() {
-        return a + b + c;
-    };
-};
-const arrowWrapperReturnArrowFunction = (a, b, c)=>{
-    return async ()=>{
-        return a + b + c;
-    };
-};
-const arrowWrapperReturnNamedFunctionVar = (a, b, c)=>{
-    async function fn() {
-        return a + b + c;
-    }
-    return fn;
-};
 export async function wflow() {
     throw new Error("You attempted to execute workflow wflow function directly. To start a workflow, use start(wflow) from workflow/api");
 }