Skip to content

Add e2e test for workflow failing when step exhausts max retries #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
+78 −37
Draft

Add e2e test for workflow failing when step exhausts max retries #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e357d65
Initial plan
Copilot Nov 26, 2025
947f55c
Fix workflow not being marked as failed when step exhausts max retries
Copilot Nov 26, 2025
373a5a7
Add test for workflow failing after step exhausts max retries
Copilot Nov 26, 2025
8e7a4ae
Fix workflow not being marked as failed when step exhausts max retries
Copilot Nov 26, 2025
7990de1
Revert incorrect fix: let step errors bubble up to workflow function
Copilot Nov 26, 2025
2964d3b
Add e2e test for workflow failing when step exhausts max retries
Copilot Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 37 additions & 37 deletions docs/app/(home)/components/frameworks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
"use client";
'use client';

import { track } from "@vercel/analytics";
import Link from "next/link";
import type { ComponentProps } from "react";
import { toast } from "sonner";
import { Badge } from "@/components/ui/badge";
import { track } from '@vercel/analytics';
import Link from 'next/link';
import type { ComponentProps } from 'react';
import { toast } from 'sonner';
import { Badge } from '@/components/ui/badge';

export const Express = (props: ComponentProps<"svg">) => (
export const Express = (props: ComponentProps<'svg'>) => (
<svg
width="999"
height="223"
Expand All @@ -23,7 +23,7 @@ export const Express = (props: ComponentProps<"svg">) => (
</svg>
);

export const AstroDark = (props: ComponentProps<"svg">) => (
export const AstroDark = (props: ComponentProps<'svg'>) => (
<svg
viewBox="0 0 85 107"
fill="none"
Expand Down Expand Up @@ -63,7 +63,7 @@ export const AstroDark = (props: ComponentProps<"svg">) => (
</svg>
);

export const AstroLight = (props: ComponentProps<"svg">) => (
export const AstroLight = (props: ComponentProps<'svg'>) => (
<svg
viewBox="0 0 85 107"
fill="none"
Expand All @@ -88,7 +88,7 @@ export const AstroLight = (props: ComponentProps<"svg">) => (
</svg>
);

export const AstroGray = (props: ComponentProps<"svg">) => (
export const AstroGray = (props: ComponentProps<'svg'>) => (
<svg
viewBox="0 0 85 107"
fill="none"
Expand All @@ -113,7 +113,7 @@ export const AstroGray = (props: ComponentProps<"svg">) => (
</svg>
);

export const TanStack = (props: ComponentProps<"svg">) => (
export const TanStack = (props: ComponentProps<'svg'>) => (
<svg
viewBox="0 0 410 413"
fill="none"
Expand All @@ -134,7 +134,7 @@ export const TanStack = (props: ComponentProps<"svg">) => (
</svg>
);

export const TanStackGray = (props: ComponentProps<"svg">) => (
export const TanStackGray = (props: ComponentProps<'svg'>) => (
<svg
viewBox="0 0 409 413"
fill="none"
Expand All @@ -148,7 +148,7 @@ export const TanStackGray = (props: ComponentProps<"svg">) => (
</svg>
);

export const Vite = (props: ComponentProps<"svg">) => (
export const Vite = (props: ComponentProps<'svg'>) => (
<svg
width="410"
height="404"
Expand Down Expand Up @@ -194,7 +194,7 @@ export const Vite = (props: ComponentProps<"svg">) => (
</svg>
);

export const Nitro = (props: ComponentProps<"svg">) => (
export const Nitro = (props: ComponentProps<'svg'>) => (
<svg
xmlns="http://www.w3.org/2000/svg"
fill="none"
Expand All @@ -211,7 +211,7 @@ export const Nitro = (props: ComponentProps<"svg">) => (
/>
<mask
id="mask0_115_108"
style={{ maskType: "alpha" }}
style={{ maskType: 'alpha' }}
maskUnits="userSpaceOnUse"
x="0"
y="0"
Expand Down Expand Up @@ -283,7 +283,7 @@ export const Nitro = (props: ComponentProps<"svg">) => (
</svg>
);

export const SvelteKit = (props: ComponentProps<"svg">) => (
export const SvelteKit = (props: ComponentProps<'svg'>) => (
<svg
xmlns="http://www.w3.org/2000/svg"
xmlnsXlink="http://www.w3.org/1999/xlink"
Expand All @@ -306,7 +306,7 @@ export const SvelteKit = (props: ComponentProps<"svg">) => (
</svg>
);

export const SvelteKitGray = (props: ComponentProps<"svg">) => (
export const SvelteKitGray = (props: ComponentProps<'svg'>) => (
<svg
xmlns="http://www.w3.org/2000/svg"
xmlnsXlink="http://www.w3.org/1999/xlink"
Expand All @@ -329,7 +329,7 @@ export const SvelteKitGray = (props: ComponentProps<"svg">) => (
</svg>
);

export const Nuxt = (props: ComponentProps<"svg">) => (
export const Nuxt = (props: ComponentProps<'svg'>) => (
<svg
viewBox="0 0 424 283"
fill="none"
Expand All @@ -344,7 +344,7 @@ export const Nuxt = (props: ComponentProps<"svg">) => (
</svg>
);

export const NuxtGray = (props: ComponentProps<"svg">) => (
export const NuxtGray = (props: ComponentProps<'svg'>) => (
<svg
viewBox="0 0 424 283"
fill="none"
Expand All @@ -359,7 +359,7 @@ export const NuxtGray = (props: ComponentProps<"svg">) => (
</svg>
);

export const Hono = (props: ComponentProps<"svg">) => (
export const Hono = (props: ComponentProps<'svg'>) => (
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 76 98" {...props}>
<title>Hono</title>
<path
Expand All @@ -376,7 +376,7 @@ export const Hono = (props: ComponentProps<"svg">) => (
</svg>
);

export const HonoGray = (props: ComponentProps<"svg">) => (
export const HonoGray = (props: ComponentProps<'svg'>) => (
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 76 98" {...props}>
<title>Hono</title>
<path
Expand All @@ -396,7 +396,7 @@ export const HonoGray = (props: ComponentProps<"svg">) => (
</svg>
);

export const Bun = (props: ComponentProps<"svg">) => (
export const Bun = (props: ComponentProps<'svg'>) => (
<svg
xmlns="http://www.w3.org/2000/svg"
id="Bun"
Expand Down Expand Up @@ -430,7 +430,7 @@ export const Bun = (props: ComponentProps<"svg">) => (
id="Top"
d="M35.12,5.53A16.41,16.41,0,0,1,29.49,18c-.28.25-.06.73.3.59,3.37-1.31,7.92-5.23,6-13.14C35.71,5,35.12,5.12,35.12,5.53Zm2.27,0A16.24,16.24,0,0,1,39,19c-.12.35.31.65.55.36C41.74,16.56,43.65,11,37.93,5,37.64,4.74,37.19,5.14,37.39,5.49Zm2.76-.17A16.42,16.42,0,0,1,47,17.12a.33.33,0,0,0,.65.11c.92-3.49.4-9.44-7.17-12.53C40.08,4.54,39.82,5.08,40.15,5.32ZM21.69,15.76a16.94,16.94,0,0,0,10.47-9c.18-.36.75-.22.66.18-1.73,8-7.52,9.67-11.12,9.45C21.32,16.4,21.33,15.87,21.69,15.76Z"
fill="#ccbea7"
style={{ fillRule: "evenodd" }}
style={{ fillRule: 'evenodd' }}
/>
<path
id="Outline"
Expand Down Expand Up @@ -485,19 +485,19 @@ export const Bun = (props: ComponentProps<"svg">) => (
<path
id="Eyes"
d="M25.7,38.8a5.51,5.51,0,1,0-5.5-5.51A5.51,5.51,0,0,0,25.7,38.8Zm24.77,0A5.51,5.51,0,1,0,45,33.29,5.5,5.5,0,0,0,50.47,38.8Z"
style={{ fillRule: "evenodd" }}
style={{ fillRule: 'evenodd' }}
/>
<path
id="Iris"
d="M24,33.64a2.07,2.07,0,1,0-2.06-2.07A2.07,2.07,0,0,0,24,33.64Zm24.77,0a2.07,2.07,0,1,0-2.06-2.07A2.07,2.07,0,0,0,48.75,33.64Z"
style={{ fillRule: "evenodd" }}
style={{ fillRule: 'evenodd' }}
fill="#fff"
/>
</g>
</svg>
);

export const BunGray = (props: ComponentProps<"svg">) => (
export const BunGray = (props: ComponentProps<'svg'>) => (
<svg
xmlns="http://www.w3.org/2000/svg"
id="Bun"
Expand Down Expand Up @@ -534,7 +534,7 @@ export const BunGray = (props: ComponentProps<"svg">) => (
id="Top"
d="M35.12,5.53A16.41,16.41,0,0,1,29.49,18c-.28.25-.06.73.3.59,3.37-1.31,7.92-5.23,6-13.14C35.71,5,35.12,5.12,35.12,5.53Zm2.27,0A16.24,16.24,0,0,1,39,19c-.12.35.31.65.55.36C41.74,16.56,43.65,11,37.93,5,37.64,4.74,37.19,5.14,37.39,5.49Zm2.76-.17A16.42,16.42,0,0,1,47,17.12a.33.33,0,0,0,.65.11c.92-3.49.4-9.44-7.17-12.53C40.08,4.54,39.82,5.08,40.15,5.32ZM21.69,15.76a16.94,16.94,0,0,0,10.47-9c.18-.36.75-.22.66.18-1.73,8-7.52,9.67-11.12,9.45C21.32,16.4,21.33,15.87,21.69,15.76Z"
fill="var(--color-background)"
style={{ fillRule: "evenodd" }}
style={{ fillRule: 'evenodd' }}
/>
<path
id="Outline"
Expand Down Expand Up @@ -596,20 +596,20 @@ export const BunGray = (props: ComponentProps<"svg">) => (
<path
id="Eyes"
d="M25.7,38.8a5.51,5.51,0,1,0-5.5-5.51A5.51,5.51,0,0,0,25.7,38.8Zm24.77,0A5.51,5.51,0,1,0,45,33.29,5.5,5.5,0,0,0,50.47,38.8Z"
style={{ fillRule: "evenodd" }}
style={{ fillRule: 'evenodd' }}
fill="var(--color-muted-foreground)"
/>
<path
id="Iris"
d="M24,33.64a2.07,2.07,0,1,0-2.06-2.07A2.07,2.07,0,0,0,24,33.64Zm24.77,0a2.07,2.07,0,1,0-2.06-2.07A2.07,2.07,0,0,0,48.75,33.64Z"
style={{ fillRule: "evenodd" }}
style={{ fillRule: 'evenodd' }}
fill="var(--color-background)"
/>
</g>
</svg>
);

export const Nest = (props: ComponentProps<"svg">) => (
export const Nest = (props: ComponentProps<'svg'>) => (
<svg
xmlns="http://www.w3.org/2000/svg"
id="NestJS"
Expand All @@ -625,7 +625,7 @@ export const Nest = (props: ComponentProps<"svg">) => (
</svg>
);

export const NestGray = (props: ComponentProps<"svg">) => (
export const NestGray = (props: ComponentProps<'svg'>) => (
<svg
xmlns="http://www.w3.org/2000/svg"
id="NestJS"
Expand All @@ -641,7 +641,7 @@ export const NestGray = (props: ComponentProps<"svg">) => (
</svg>
);

export const Next = (props: ComponentProps<"svg">) => (
export const Next = (props: ComponentProps<'svg'>) => (
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 128 128" {...props}>
<title>Next.js</title>
<circle cx="64" cy="64" r="62" strokeWidth="4" className="stroke-border" />
Expand Down Expand Up @@ -681,8 +681,8 @@ export const Next = (props: ComponentProps<"svg">) => (

export const Frameworks = () => {
const handleRequest = (framework: string) => {
track("Framework requested", { framework: framework.toLowerCase() });
toast.success("Request received", {
track('Framework requested', { framework: framework.toLowerCase() });
toast.success('Request received', {
description: `Thanks for expressing interest in ${framework}. We will be adding support for it soon.`,
});
};
Expand Down Expand Up @@ -742,21 +742,21 @@ export const Frameworks = () => {
</div>
<div
className="group relative cursor-pointer size-[48px]"
onClick={() => handleRequest("NestJS")}
onClick={() => handleRequest('NestJS')}
>
<NestGray className="size-[48px] opacity-70 transition-all duration-200 group-hover:opacity-0 group-hover:scale-95" />
<Nest className="size-[48px] absolute inset-0 opacity-0 scale-95 transition-all duration-200 group-hover:opacity-100 group-hover:scale-100" />
</div>
<div
className="group relative cursor-pointer size-[48px]"
onClick={() => handleRequest("TanStack")}
onClick={() => handleRequest('TanStack')}
>
<TanStackGray className="size-[48px] opacity-70 transition-all duration-200 group-hover:opacity-0 group-hover:scale-95" />
<TanStack className="size-[48px] absolute inset-0 opacity-0 scale-95 transition-all duration-200 group-hover:opacity-100 group-hover:scale-100 dark:invert" />
</div>
<div
className="group relative cursor-pointer size-[48px]"
onClick={() => handleRequest("Astro")}
onClick={() => handleRequest('Astro')}
>
<AstroGray className="size-[48px] opacity-70 transition-all duration-200 group-hover:opacity-0 group-hover:scale-95" />
<AstroDark className="size-[48px] absolute inset-0 opacity-0 scale-95 transition-all duration-200 group-hover:opacity-100 group-hover:scale-100 hidden dark:block" />
Expand Down
23 changes: 23 additions & 0 deletions packages/core/e2e/e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
body: JSON.stringify(dehydratedArgs),
});
if (!res.ok) {
throw new Error(

Check failure on line 36 in packages/core/e2e/e2e.test.ts

View workflow job for this annotation

GitHub Actions / E2E Local Dev Tests (hono - stable)

packages/core/e2e/e2e.test.ts > e2e > sleepingWorkflow 

Error: Failed to trigger workflow: http://localhost:3000/api/trigger?workflowFile=workflows%2F99_e2e.ts&workflowFn=sleepingWorkflow 500: {
  "error": true,
  "url": "http://localhost:3000/api/trigger?workflowFile=workflows%2F99_e2e.ts&workflowFn=sleepingWorkflow",
  "status": 500,
  "message": "lowEntrypoint is not defined",
  "stack": [
    "lowEntrypoint is not defined",
    "at #generateError (/home/runner/work/workflow/workflow/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@aws-sdk+credential-pr_fb2b7b7d6de91cf225d3009eeef8648d/node_modules/nitro/dist/_dev.mjs:687:11)",
    "at /home/runner/work/workflow/workflow/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@aws-sdk+credential-pr_fb2b7b7d6de91cf225d3009eeef8648d/node_modules/nitro/dist/_dev.mjs:560:43)"
  ]
}
 ❯ triggerWorkflow packages/core/e2e/e2e.test.ts:36:11
 ❯ packages/core/e2e/e2e.test.ts:312:17

Check failure on line 36 in packages/core/e2e/e2e.test.ts

View workflow job for this annotation

GitHub Actions / E2E Local Dev Tests (hono - stable)

packages/core/e2e/e2e.test.ts > e2e > webhookWorkflow 

Error: Failed to trigger workflow: http://localhost:3000/api/trigger?workflowFile=workflows%2F99_e2e.ts&workflowFn=webhookWorkflow 500: {
  "error": true,
  "url": "http://localhost:3000/api/trigger?workflowFile=workflows%2F99_e2e.ts&workflowFn=webhookWorkflow",
  "status": 500,
  "message": "lowEntrypoint is not defined",
  "stack": [
    "lowEntrypoint is not defined",
    "at #generateError (/home/runner/work/workflow/workflow/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@aws-sdk+credential-pr_fb2b7b7d6de91cf225d3009eeef8648d/node_modules/nitro/dist/_dev.mjs:687:11)",
    "at /home/runner/work/workflow/workflow/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@aws-sdk+credential-pr_fb2b7b7d6de91cf225d3009eeef8648d/node_modules/nitro/dist/_dev.mjs:560:43)"
  ]
}
 ❯ triggerWorkflow packages/core/e2e/e2e.test.ts:36:11
 ❯ packages/core/e2e/e2e.test.ts:212:17

Check failure on line 36 in packages/core/e2e/e2e.test.ts

View workflow job for this annotation

GitHub Actions / E2E Local Dev Tests (hono - stable)

packages/core/e2e/e2e.test.ts > e2e > hookWorkflow 

Error: Failed to trigger workflow: http://localhost:3000/api/trigger?workflowFile=workflows%2F99_e2e.ts&workflowFn=hookWorkflow 500: {
  "error": true,
  "url": "http://localhost:3000/api/trigger?workflowFile=workflows%2F99_e2e.ts&workflowFn=hookWorkflow",
  "status": 500,
  "message": "lowEntrypoint is not defined",
  "stack": [
    "lowEntrypoint is not defined",
    "at #generateError (/home/runner/work/workflow/workflow/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@aws-sdk+credential-pr_fb2b7b7d6de91cf225d3009eeef8648d/node_modules/nitro/dist/_dev.mjs:687:11)",
    "at /home/runner/work/workflow/workflow/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@aws-sdk+credential-pr_fb2b7b7d6de91cf225d3009eeef8648d/node_modules/nitro/dist/_dev.mjs:560:43)"
  ]
}
 ❯ triggerWorkflow packages/core/e2e/e2e.test.ts:36:11
 ❯ packages/core/e2e/e2e.test.ts:149:17

Check failure on line 36 in packages/core/e2e/e2e.test.ts

View workflow job for this annotation

GitHub Actions / E2E Local Dev Tests (hono - stable)

packages/core/e2e/e2e.test.ts > e2e > readableStreamWorkflow 

Error: Failed to trigger workflow: http://localhost:3000/api/trigger?workflowFile=workflows%2F99_e2e.ts&workflowFn=readableStreamWorkflow 500: {
  "error": true,
  "url": "http://localhost:3000/api/trigger?workflowFile=workflows%2F99_e2e.ts&workflowFn=readableStreamWorkflow",
  "status": 500,
  "message": "lowEntrypoint is not defined",
  "stack": [
    "lowEntrypoint is not defined",
    "at #generateError (/home/runner/work/workflow/workflow/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@aws-sdk+credential-pr_fb2b7b7d6de91cf225d3009eeef8648d/node_modules/nitro/dist/_dev.mjs:687:11)",
    "at /home/runner/work/workflow/workflow/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@aws-sdk+credential-pr_fb2b7b7d6de91cf225d3009eeef8648d/node_modules/nitro/dist/_dev.mjs:560:43)"
  ]
}
 ❯ triggerWorkflow packages/core/e2e/e2e.test.ts:36:11
 ❯ packages/core/e2e/e2e.test.ts:132:17

Check failure on line 36 in packages/core/e2e/e2e.test.ts

View workflow job for this annotation

GitHub Actions / E2E Local Dev Tests (hono - stable)

packages/core/e2e/e2e.test.ts > e2e > promiseAnyWorkflow 

Error: Failed to trigger workflow: http://localhost:3000/api/trigger?workflowFile=workflows%2F99_e2e.ts&workflowFn=promiseAnyWorkflow 500: {
  "error": true,
  "url": "http://localhost:3000/api/trigger?workflowFile=workflows%2F99_e2e.ts&workflowFn=promiseAnyWorkflow",
  "status": 500,
  "message": "lowEntrypoint is not defined",
  "stack": [
    "lowEntrypoint is not defined",
    "at #generateError (/home/runner/work/workflow/workflow/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@aws-sdk+credential-pr_fb2b7b7d6de91cf225d3009eeef8648d/node_modules/nitro/dist/_dev.mjs:687:11)",
    "at /home/runner/work/workflow/workflow/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@aws-sdk+credential-pr_fb2b7b7d6de91cf225d3009eeef8648d/node_modules/nitro/dist/_dev.mjs:560:43)"
  ]
}
 ❯ triggerWorkflow packages/core/e2e/e2e.test.ts:36:11
 ❯ packages/core/e2e/e2e.test.ts:126:17

Check failure on line 36 in packages/core/e2e/e2e.test.ts

View workflow job for this annotation

GitHub Actions / E2E Local Dev Tests (hono - stable)

packages/core/e2e/e2e.test.ts > e2e > promiseRaceWorkflow 

Error: Failed to trigger workflow: http://localhost:3000/api/trigger?workflowFile=workflows%2F99_e2e.ts&workflowFn=promiseRaceWorkflow 500: {
  "error": true,
  "url": "http://localhost:3000/api/trigger?workflowFile=workflows%2F99_e2e.ts&workflowFn=promiseRaceWorkflow",
  "status": 500,
  "message": "lowEntrypoint is not defined",
  "stack": [
    "lowEntrypoint is not defined",
    "at #generateError (/home/runner/work/workflow/workflow/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@aws-sdk+credential-pr_fb2b7b7d6de91cf225d3009eeef8648d/node_modules/nitro/dist/_dev.mjs:687:11)",
    "at /home/runner/work/workflow/workflow/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@aws-sdk+credential-pr_fb2b7b7d6de91cf225d3009eeef8648d/node_modules/nitro/dist/_dev.mjs:560:43)"
  ]
}
 ❯ triggerWorkflow packages/core/e2e/e2e.test.ts:36:11
 ❯ packages/core/e2e/e2e.test.ts:120:17

Check failure on line 36 in packages/core/e2e/e2e.test.ts

View workflow job for this annotation

GitHub Actions / E2E Local Dev Tests (hono - stable)

packages/core/e2e/e2e.test.ts > e2e > promiseAllWorkflow 

Error: Failed to trigger workflow: http://localhost:3000/api/trigger?workflowFile=workflows%2F99_e2e.ts&workflowFn=promiseAllWorkflow 500: {
  "error": true,
  "url": "http://localhost:3000/api/trigger?workflowFile=workflows%2F99_e2e.ts&workflowFn=promiseAllWorkflow",
  "status": 500,
  "message": "lowEntrypoint is not defined",
  "stack": [
    "lowEntrypoint is not defined",
    "at #generateError (/home/runner/work/workflow/workflow/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@aws-sdk+credential-pr_fb2b7b7d6de91cf225d3009eeef8648d/node_modules/nitro/dist/_dev.mjs:687:11)",
    "at /home/runner/work/workflow/workflow/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@aws-sdk+credential-pr_fb2b7b7d6de91cf225d3009eeef8648d/node_modules/nitro/dist/_dev.mjs:560:43)"
  ]
}
 ❯ triggerWorkflow packages/core/e2e/e2e.test.ts:36:11
 ❯ packages/core/e2e/e2e.test.ts:114:17

Check failure on line 36 in packages/core/e2e/e2e.test.ts

View workflow job for this annotation

GitHub Actions / E2E Local Dev Tests (hono - stable)

packages/core/e2e/e2e.test.ts > e2e > addTenWorkflow 

Error: Failed to trigger workflow: http://localhost:3000/api/trigger?workflowFile=workflows%2F98_duplicate_case.ts&workflowFn=addTenWorkflow 500: {
  "error": true,
  "url": "http://localhost:3000/api/trigger?workflowFile=workflows%2F98_duplicate_case.ts&workflowFn=addTenWorkflow",
  "status": 500,
  "message": "lowEntrypoint is not defined",
  "stack": [
    "lowEntrypoint is not defined",
    "at #generateError (/home/runner/work/workflow/workflow/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@aws-sdk+credential-pr_fb2b7b7d6de91cf225d3009eeef8648d/node_modules/nitro/dist/_dev.mjs:687:11)",
    "at /home/runner/work/workflow/workflow/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@aws-sdk+credential-pr_fb2b7b7d6de91cf225d3009eeef8648d/node_modules/nitro/dist/_dev.mjs:560:43)"
  ]
}
 ❯ triggerWorkflow packages/core/e2e/e2e.test.ts:36:11
 ❯ packages/core/e2e/e2e.test.ts:92:17

Check failure on line 36 in packages/core/e2e/e2e.test.ts

View workflow job for this annotation

GitHub Actions / E2E Local Dev Tests (hono - stable)

packages/core/e2e/e2e.test.ts > e2e > addTenWorkflow 

Error: Failed to trigger workflow: http://localhost:3000/api/trigger?workflowFile=workflows%2F99_e2e.ts&workflowFn=addTenWorkflow 500: {
  "error": true,
  "url": "http://localhost:3000/api/trigger?workflowFile=workflows%2F99_e2e.ts&workflowFn=addTenWorkflow",
  "status": 500,
  "message": "lowEntrypoint is not defined",
  "stack": [
    "lowEntrypoint is not defined",
    "at #generateError (/home/runner/work/workflow/workflow/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@aws-sdk+credential-pr_fb2b7b7d6de91cf225d3009eeef8648d/node_modules/nitro/dist/_dev.mjs:687:11)",
    "at /home/runner/work/workflow/workflow/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@aws-sdk+credential-pr_fb2b7b7d6de91cf225d3009eeef8648d/node_modules/nitro/dist/_dev.mjs:560:43)"
  ]
}
 ❯ triggerWorkflow packages/core/e2e/e2e.test.ts:36:11
 ❯ packages/core/e2e/e2e.test.ts:92:17
`Failed to trigger workflow: ${res.url} ${
res.status
}: ${await res.text()}`
Expand Down Expand Up @@ -303,7 +303,7 @@
method: 'POST',
body: JSON.stringify({}),
});
expect(res.status).toBe(404);

Check failure on line 306 in packages/core/e2e/e2e.test.ts

View workflow job for this annotation

GitHub Actions / E2E Local Dev Tests (hono - stable)

packages/core/e2e/e2e.test.ts > e2e > webhook route with invalid token 

AssertionError: expected 500 to be 404 // Object.is equality

- Expected
+ Received

- 404
+ 500

 ❯ packages/core/e2e/e2e.test.ts:306:24
const body = await res.text();
expect(body).toBe('');
});
Expand Down Expand Up @@ -776,4 +776,27 @@
expect(returnValue).toBe('Result: 21');
}
);

test(
'stepExhaustsRetriesWorkflow - workflow fails when step exhausts max retries',
{ timeout: 120_000 },
async () => {
// This workflow has a step that always throws a regular error.
// After exhausting max retries (default 3), the error should bubble up
// to the workflow function. Since the workflow doesn't handle it,
// the workflow run should enter a failed state.
const run = await triggerWorkflow('stepExhaustsRetriesWorkflow', []);
const returnValue = await getWorkflowReturnValue(run.runId);

// The workflow should fail with WorkflowRunFailedError
expect(returnValue).toHaveProperty('name');
expect(returnValue.name).toBe('WorkflowRunFailedError');

// Verify the run is in failed status
const { json: runData } = await cliInspectJson(`runs ${run.runId}`);
expect(runData.status).toBe('failed');
expect(runData.error).toBeDefined();
expect(runData.error.message).toContain('failed after max retries');
}
);
});
18 changes: 18 additions & 0 deletions workbench/example/workflows/99_e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,3 +559,21 @@ export async function closureVariableWorkflow(baseValue: number) {
const output = await calculate();
return output;
}

//////////////////////////////////////////////////////////

// Step that always throws a regular error (not FatalError)
// This will exhaust max retries and the error should bubble up to the workflow
async function stepThatAlwaysFailsWithRegularError() {
'use step';
throw new Error('This step always fails with a regular error');
}

// Workflow that calls a step that always fails
// The step will exhaust max retries and the error should bubble up,
// causing the workflow run to enter a failed state
export async function stepExhaustsRetriesWorkflow() {
'use workflow';
await stepThatAlwaysFailsWithRegularError();
return 'never reached';
}
Loading