MultipartFormUpload: use MemoryAttribute (#2561)

Related to #2308

When creating a simple attribute, use memory storage, regardless of the value size.

Otherwise, Netty creates a temporary file when the size if above the default limit (16KB).

Signed-off-by: Thomas Segismont <[email protected]>

Author: tsegismont

vertx-web-client/src/main/java/io/vertx/ext/web/client/impl/MultipartFormUpload.java

@@ -17,15 +17,8 @@
 
 import io.netty.buffer.ByteBuf;
 import io.netty.buffer.UnpooledByteBufAllocator;
-import io.netty.handler.codec.http.DefaultFullHttpRequest;
-import io.netty.handler.codec.http.HttpConstants;
-import io.netty.handler.codec.http.HttpContent;
-import io.netty.handler.codec.http.HttpRequest;
-import io.netty.handler.codec.http.HttpVersion;
-import io.netty.handler.codec.http.multipart.DefaultHttpDataFactory;
-import io.netty.handler.codec.http.multipart.FileUpload;
-import io.netty.handler.codec.http.multipart.HttpPostRequestEncoder;
-import io.netty.handler.codec.http.multipart.MemoryFileUpload;
+import io.netty.handler.codec.http.*;
+import io.netty.handler.codec.http.multipart.*;
 import io.vertx.core.Context;
 import io.vertx.core.Handler;
 import io.vertx.core.MultiMap;
@@ -39,6 +32,7 @@
 import io.vertx.ext.web.multipart.MultipartForm;
 
 import java.io.File;
+import java.io.IOException;
 import java.nio.charset.Charset;
 
 /**
@@ -75,6 +69,15 @@ public MultipartFormUpload(Context context,
     Charset charset = parts.getCharset() != null ? parts.getCharset() : HttpConstants.DEFAULT_CHARSET;
     this.encoder = new HttpPostRequestEncoder(
       new DefaultHttpDataFactory(DefaultHttpDataFactory.MINSIZE, charset) {
+        @Override
+        public Attribute createAttribute(HttpRequest request, String name, String value) {
+          try {
+            return new MemoryAttribute(name, value, charset);
+          } catch (IOException e) {
+            throw new IllegalArgumentException(e);
+          }
+        }
+
         @Override
         public FileUpload createFileUpload(HttpRequest request, String name, String filename, String contentType, String contentTransferEncoding, Charset _charset, long size) {
           if (_charset == null) {