Skip to content

Commit c3be734

Browse files
authored
Backport to and test on Node 10 (#164)
1 parent 415ca07 commit c3be734

File tree

6 files changed

+20
-1
lines changed

6 files changed

+20
-1
lines changed

.github/workflows/test.yml

+4
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,10 @@ jobs:
1717
steps:
1818
- name: Checkout code
1919
uses: actions/checkout@v2
20+
- name: Use Ubuntu 20.04's nodejs
21+
uses: actions/setup-node@v2
22+
with:
23+
node-version: 10.x
2024
- name: Install node modules
2125
run: npm install
2226
- name: Install latest vg release

.npmrc

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
engine-strict=true
2+

.nvmrc

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
v10.24.1

package-lock.json

+5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+5-1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
"gh-pages": "^3.2.3",
2424
"multer": "^1.4.4",
2525
"path-is-inside": "^1.0.2",
26+
"polyfill-object.fromentries": "^1.0.1",
2627
"prop-types": "^15.7.2",
2728
"react": "^17.0.2",
2829
"react-dom": "^17.0.2",
@@ -52,5 +53,8 @@
5253
"not dead",
5354
"not ie <= 11",
5455
"not op_mini all"
55-
]
56+
],
57+
"engines": {
58+
"node": ">=10.0.0"
59+
}
5660
}

src/App.js

+3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
import React, { Component } from "react";
22
import PropTypes from "prop-types";
33
import isEqual from "react-fast-compare";
4+
// Needed for Node <12
5+
// TODO: remove import and dependency when we upgrade.
6+
import {} from "polyfill-object.fromentries";
47

58
import "./App.css";
69
import HeaderForm from "./components/HeaderForm";

0 commit comments

Comments
 (0)