Environmental summary banner #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
78
to
94
| const fetchArrangerData = ({ | ||
| endpointTag, | ||
| query, | ||
| sqon, | ||
| }: { | ||
| endpointTag?: string; | ||
| query: string; | ||
| sqon?: SQONType; | ||
| }) => { | ||
| return arrangerFetcher({ | ||
| body: { | ||
| query: query, | ||
| variables: { sqon }, | ||
| }, | ||
| endpointTag, | ||
| }); | ||
| }; |
There was a problem hiding this comment.
this part doesn't need to be duplicated, as it's a shared function...
thinking the structure of these hooks could be turned around.
i.e. now:
hooks/clinical/useReleaseData/index.ts
hooks/environmental/useReleaseData/index.ts
vs:
hooks/useReleaseData/index.ts implements environmental.ts and clinical.ts, reusing code in index.
There was a problem hiding this comment.
Thanks for noticing this! I just changed the code to organize hooks/useReleaseData/index.ts to include the shared code, whereas in environmental.ts and clinical.ts contain specific code.
justincorrigible
approved these changes
Mar 12, 2025
Co-authored-by: Anders Richardsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement Environmental Summary Banner on Home page. Data is recollected through Arranger which aggregates the relevant results for display.
UI Changes
Environment variables
Changes uses the environment variables to get the exact number of records:
NEXT_PUBLIC_ARRANGER_ENVIRONMENTAL_CARDINALITY_PRECISION_THRESHOLD: Precision threshold to count number of samples in the bucket. Default 3000NEXT_PUBLIC_ARRANGER_ENVIRONMENTAL_MAX_BUCKET_COUNTS: the max number or records in the bucket. Used to get exact number of samples . Default 1000Refactoring
Issue Releated:
Waste Water: #58