Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Introduce VTTablet flag to control zstdInMemoryDecompressorMaxSize #17219

Open
notfelineit opened this issue Nov 12, 2024 · 0 comments · May be fixed by #17220
Open

Feature Request: Introduce VTTablet flag to control zstdInMemoryDecompressorMaxSize #17219

notfelineit opened this issue Nov 12, 2024 · 0 comments · May be fixed by #17220

Comments

@notfelineit
Copy link
Contributor

Feature Description

Sometimes the current limit at which Vitess switches from in-memory buffer to streaming is still too high to prevent mysql OOMs:

zstdInMemoryDecompressorMaxSize = 128 << (10 * 2) // 128MiB

It would be nice to be able to conditionally set this based on other infrastructure resource settings, as a VTTablet flag.

Use Case(s)

  1. Our VTTablet is on a smaller Kubernetes pod size
  2. We set zstdInMemoryDecompressorMaxSize to stream at a lower threshold, since VTTablet resources are less
@notfelineit notfelineit added Needs Triage This issue needs to be correctly labelled and triaged Type: Feature Component: VReplication go labels Nov 12, 2024
@mattlord mattlord removed the Needs Triage This issue needs to be correctly labelled and triaged label Nov 12, 2024
@mattlord mattlord self-assigned this Nov 12, 2024
@github-project-automation github-project-automation bot moved this to Backlog in VReplication Nov 12, 2024
@mattlord mattlord moved this from Backlog to In progress in VReplication Nov 12, 2024
@mattlord mattlord linked a pull request Nov 13, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

2 participants