driver: errors fix

Author: medvednikov

vlib/v/driver/environment_test.v

@@ -240,15 +240,22 @@ fn test_v3_default_diagnostic_color_uses_environment() {
 	assert ansi.red('error') == '\x1b[31merror\x1b[39m'
 }
 
-fn test_release_unused_diagnostic_scope_rebinds_notices() {
+fn test_release_unused_diagnostic_scope_preserves_errors_and_rebinds_notices() {
+	mut errors := []types.TypeError{cap: 1}
 	mut notices := []types.TypeError{cap: 1}
 	scope := prealloc_scope_begin_for_v3()
+	errors << types.TypeError{ msg: 'first error' }
+	errors << types.TypeError{ msg: 'second error' }
 	notices << types.TypeError{ msg: 'first' }
 	notices << types.TypeError{ msg: 'second' }
 	$if prealloc {
+		assert scoped_value_owned(scope, errors.data)
 		assert scoped_value_owned(scope, notices.data)
 	}
-	release_unused_diagnostic_scope(mut notices, scope)
+	release_unused_diagnostic_scope(mut errors, mut notices, scope)
+	assert errors.len == 2
+	assert errors[0].msg == 'first error'
+	assert errors[1].msg == 'second error'
 	assert notices.len == 0
 	assert notices.cap == 0
 	notices << types.TypeError{ msg: 'parent owned' }

vlib/v/types/checker_comptime.v

@@ -4389,15 +4389,9 @@ fn (mut tc TypeChecker) check_cast_expr(id flat.NodeId, node flat.Node) {
 			}
 			return
 		}
-		actual_pointer := unalias_type(actual)
-		same_pointer_type := if actual_pointer is Pointer {
-			tc.type_compatible(actual_pointer.base_type, target_pointer.base_type)
-		} else {
-			false
-		}
 		if tc.unsafe_depth == 0 && !(target is Alias && tc.alias_type_is_shared(target))
-			&& actual_pointer is Pointer && struct_type_from_type(target_base) != none
-			&& actual.name() != target_name && !same_pointer_type {
+			&& unalias_type(actual) is Pointer && struct_type_from_type(target_base) != none
+			&& actual.name() != target_name {
 			tc.record_warning_at(.assignment_mismatch, 'casting `${actual.name()}` to `${target_name}` is only allowed in `unsafe` code', id, node.pos)
 			return
 		}

vlib/v/types/checker_parallel.v

@@ -908,19 +908,16 @@ fn (tc &TypeChecker) scan_unused_alive_range(fn_keys map[string][]int, const_key
 					alive[cand_idx] = true
 				}
 			}
-			if hits := fn_keys[node.value] {
-				for cand_idx in hits {
-					alive[cand_idx] = true
-				}
-			}
 			short_name := short_name_view(node.value)
 			if short_name.len != node.value.len {
 				if hits := const_keys[short_name] {
 					for cand_idx in hits {
 						alive[cand_idx] = true
 					}
 				}
-				if hits := fn_keys[short_name] {
+			}
+			if resolved := tc.resolved_fn_value_name(flat.NodeId(i)) {
+				if hits := fn_keys[resolved] {
 					for cand_idx in hits {
 						alive[cand_idx] = true
 					}