Skip to content

Commit 8bfbfff

Browse files
committed
fix rust ndk build issue using cargo-ndk
1 parent aed8b22 commit 8bfbfff

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

.github/workflows/publish.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,9 @@ jobs:
166166
local-cache: true
167167
add-to-path: false
168168

169+
- name: Cargo NDK
170+
run: cargo install cargo-ndk
171+
169172
- name: Build
170173
env:
171174
ANDROID_NDK_HOME: ${{ steps.setup-ndk.outputs.ndk-path }}

core/Makefile

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,16 @@ endif
4242
# https://github.com/marketplace/actions/setup-android-ndk
4343
ifdef ANDROID_TARGET
4444
CI_MAYBE_TARGET=$(ANDROID_TARGET)
45-
NDK = $(ANDROID_NDK_HOME) # ANDROID_NDK_HOME is an env variable
45+
NDK = $(ANDROID_NDK_HOME)
4646
NDK_HOSTARCH = linux-x86_64
47+
# NDK_HOSTARCH = darwin-x86_64
4748
CC = $(NDK)/toolchains/llvm/prebuilt/$(NDK_HOSTARCH)/bin/clang
48-
49+
rs_ndk = ndk -t $(ANDROID_TARGET)
50+
# unset rs target?
4951
rs_build_flags = -Zbuild-std
50-
sysroot_option = --sysroot=$(NDK)/toolchains/llvm/prebuilt/$(NDK_HOSTARCH)/sysroot
52+
sysroot_option = --sysroot="$(NDK)/toolchains/llvm/prebuilt/$(NDK_HOSTARCH)/sysroot"
53+
# android_I = -I$(NDK)/toolchains/llvm/prebuilt/$(NDK_HOSTARCH)/sysroot/usr/include/$(ANDROID_TARGET)/asm
54+
# android_L = -L$(NDK)/toolchains/llvm/prebuilt/$(NDK_HOSTARCH)/sysroot/usr/lib/$(ANDROID_TARGET)/33
5155
endif
5256

5357
prefix=./dist
@@ -153,7 +157,7 @@ $(rs_lib_static_cpy): FORCE $(prefix)
153157
cp $(rs_lib_static) $(rs_lib_static_cpy)
154158

155159
$(rs_lib_loadable_cpy): FORCE $(prefix)
156-
cd ./rs/bundle && cargo build $(RS_TARGET) --release --features loadable_extension $(rs_build_flags)
160+
cd ./rs/bundle && cargo $(rs_ndk) build $(RS_TARGET) --release --features loadable_extension $(rs_build_flags)
157161
cp $(rs_lib_loadable) $(rs_lib_loadable_cpy)
158162

159163
$(rs_lib_dbg_loadable_cpy): FORCE $(dbg_prefix)

0 commit comments

Comments
 (0)