Skip to content

[Bug_fix] fix torchair o_proj forward parameter #4166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

[Bug_fix] fix torchair o_proj forward parameter #4166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions vllm_ascend/ops/linear.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@ def forward(
self,
input_,
is_prefill: bool = True,
is_force_scatter: bool = False,
) -> Union[torch.Tensor, tuple[torch.Tensor, Optional[Parameter]]]:
if self.custom_op is not None:
return self.custom_op.apply(input_)
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The newly added is_force_scatter parameter and the existing is_prefill parameter are not being passed to self.custom_op.apply(). This makes the fix incomplete as the custom op will not receive these values. You should pass them to the apply method. This will also require updating the signature of apply and apply_impl methods in CustomLinearOp and its subclasses in vllm_ascend/ops/linear_op.py.

Suggested change
return self.custom_op.apply(input_)
return self.custom_op.apply(input_, is_prefill=is_prefill, is_force_scatter=is_force_scatter)

Expand Down
Loading