Compilation error in vortex-array@0.56.0

[duarten]

Issue Description

With Rust 1.89.0 and above:

error[E0282]: type annotations needed
  --> /Users/duarte.nunes/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/vortex-array-0.56.0/src/expr/display.rs:30:21
   |
30 |                     Ok(Tree::new(format!("{}: {}", name, child_tree.root))
   |                     ^^ cannot infer type of the type parameter `E` declared on the enum `Result`
   |
help: consider specifying the generic arguments
   |
30 |                     Ok::<Tree<std::string::String>, E>(Tree::new(format!("{}: {}", name, child_tree.root))
   |                       ++++++++++++++++++++++++++++++++

error[E0283]: type annotations needed
  --> /Users/duarte.nunes/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/vortex-array-0.56.0/src/expr/display.rs:30:21
   |
29 |                     let child_tree = make_tree(child)?;
   |                                                      - type must be known at this point
30 |                     Ok(Tree::new(format!("{}: {}", name, child_tree.root))
   |                     ^^ cannot infer type of the type parameter `E` declared on the enum `Result`
   |
   = note: multiple `impl`s satisfying `_: From<std::fmt::Error>` found in the following crates: `idna`, `log`, `serde_fmt`, `value_bag`:
           - impl From<std::fmt::Error> for idna::punycode::PunycodeEncodeError;
           - impl From<std::fmt::Error> for idna::uts46::ProcessingError;
           - impl From<std::fmt::Error> for log::kv::Error;
           - impl From<std::fmt::Error> for serde_fmt::Error;
           - impl From<std::fmt::Error> for value_bag::error::Error;
help: consider specifying the generic arguments
   |
30 |                     Ok::<Tree<std::string::String>, E>(Tree::new(format!("{}: {}", name, child_tree.root))
   |                       ++++++++++++++++++++++++++++++++

error[E0283]: type annotations needed
  --> /Users/duarte.nunes/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/vortex-array-0.56.0/src/expr/display.rs:30:21
   |
30 |                     Ok(Tree::new(format!("{}: {}", name, child_tree.root))
   |                     ^^ cannot infer type of the type parameter `E` declared on the enum `Result`
...
35 |             Ok(Tree::new(node_name).with_leaves(child_trees?))
   |                                                            - type must be known at this point
   |
   = note: multiple `impl`s satisfying `std::fmt::Error: From<_>` found in the following crates: `core`, `serde_fmt`:
           - impl From<serde_fmt::Error> for std::fmt::Error;
           - impl<T> From<T> for T;
help: consider specifying the generic arguments
   |
30 |                     Ok::<Tree<std::string::String>, E>(Tree::new(format!("{}: {}", name, child_tree.root))

Expected Behavior

Compilation to succeed.

Actual Behavior

Compilation fails.

Reproduction Steps

Try to compile vortex-array@0.56.0

OS Version Information

macOS 15

I acknowledge that:

• I have searched the Vortex repository (both open and closed Discussions and Issues) and confirm this is not a duplicate of an existing issue or discussion.
• I have checked the "Preview" tab on all text fields to ensure that everything looks right, and have wrapped all configuration and code in code blocks with a group of three backticks (```) on separate lines.

[0ax1]

Thanks for reporting! I'm having a look.

[0ax1]

@duarten I can't reproduce the issue for either building vortex-array@0.56.0 in context of the vortex repo workspace, or when adding vortex-array = { version = "=0.56.0" } as a dependency. The build succeeds on my end with Rust 1.89.

Can you provide a minimal cargo project with which I can repro the issue?

[duarten]

I think you need to add a dependency that is also providing a conflicting impl for From<std::fmt::Error>. For example, this will fail to compile:

Cargo.toml:

[package]
name = "vortex-repro"
version = "0.1.0"
edition = "2024"
publish = false

[dependencies]
log = { version = "0.4.28", features = [ "kv_unstable_serde" ] }
vortex = "0.56.0"

src/main.rs:

fn main() {}

[0ax1]

Interesting, I can repro this if kv_unstable_serde is part of the feature list.

[0ax1]

Fixed by: #5696