Fix legacy facts

Author: dhoppe

manifests/extract.pp

@@ -70,7 +70,7 @@
   }
 
   if $strip {
-    if $::osfamily == 'Solaris' or $name !~ /(.tar|.tgz|.tar.gz|.tbz2|.tar.bz2)$/ {
+    if $facts['os']['family'] == 'Solaris' or $name !~ /(.tar|.tgz|.tar.gz|.tbz2|.tar.bz2)$/ {
       warning('strip is only supported with GNU tar, ignoring the parameter')
       $strip_opt = ''
     } else {
@@ -92,7 +92,7 @@
     }
 
     /(.tgz|.tar.gz)$/: {
-      if $::osfamily == 'Solaris' {
+      if $facts['os']['family'] == 'Solaris' {
         $command = "gunzip -dc < ${source_path} | tar xf - ${untar_opts_real}"
       } else {
         $command = "tar xzf ${source_path}${strip_opt}${untar_opts_real}"
@@ -116,7 +116,7 @@
     }
 
     /.deb$/: {
-      if $::osfamily == 'Debian' {
+      if $facts['os']['family'] == 'Debian' {
         $command = "dpkg --extract ${source_path} ."
       } else {
         fail('The .deb filetype is only supported on Debian family systems.')

manifests/params.pp

@@ -1,6 +1,6 @@
 # OS specific parameters
 class staging::params {
-  case $::osfamily {
+  case $facts['os']['family'] {
     default: {
       $path      = '/opt/staging'
       $owner     = '0'

spec/defines/staging_deploy_spec.rb

@@ -3,7 +3,7 @@
   let(:facts) do
     {
       caller_module_name: '',
-      osfamily: 'RedHat',
+      os: { family: 'RedHat' },
       staging_http_get: 'curl',
       path: '/usr/local/bin:/usr/bin:/bin'
     }

spec/defines/staging_extract_spec.rb

@@ -3,7 +3,7 @@
   # forcing a more sane caller_module_name to match real usage.
   let(:facts) do
     {
-      osfamily: 'RedHat',
+      os: { family: 'RedHat' },
       path: '/usr/local/bin:/usr/bin:/bin'
     }
   end
@@ -200,7 +200,7 @@
   describe 'when deploying deb on a Debian family system' do
     let(:facts) do
       {
-        osfamily: 'Debian',
+        os: { family: 'Debian' },
         path: '/usr/local/bin:/usr/bin:/bin'
       }
     end

spec/defines/staging_file_spec.rb

@@ -3,7 +3,7 @@
   # forcing a more sane caller_module_name to match real usage.
   let(:facts) do
     {
-      osfamily: 'RedHat',
+      os: { family: 'RedHat' },
       staging_http_get: 'curl',
       puppetversion: Puppet.version
     }