activityBar.activeBorder and tab.activeBorderTop properties are not displayed

[Aluisio]

Hello, analyzing the theme previews (and also looking at the preview of my own extension https://vscodethemes.com/e/aluisiodeavila.fuedskeps-theme/fuedskeps-blue?language=javascript ) I noticed that the activityBar.activeBorder and tab.activeBorderTop properties are not being displayed in the theme preview images.

It would be interesting if this adjustment were made so that it was displayed correctly, because from my analysis many other extensions use these two properties to differentiate the theme variants, and in this case by not showing the colors of these properties, the preview of each variant is the same.

In the case of the activityBar.activeBorder property, it is currently only showing the color if the theme uses the activityBar.foreground property, however many themes do not use this property so as not to change the color of the icon, and only change the color of the border.

In the case of the tab.activeBorderTop property, it is currently only showing the tab.activeBorder property.

Theme preview inside VSCode

Theme preview inside vscodethemes

[jschr]

Thanks for the feedback. I just launched a new version of the site which has several improvements to theme previews including the active border.

[Aluisio]

Hello @jschr
Congratulations on updating the site.
The bottom border of the tabs is now showing, but the activityBar.activeBorder property is still not showing.
I also noticed that the git tab badge is misaligned, as you can see in the photo below.

[jschr]

You're right I missed adding activityBar.activeBorder. I opened a new issue: #285

As for the alignment I did intentionally add the badge to to the Git icon since at least for me that's the one that usually has the badge.

[Aluisio]

Perfect @jschr. Now the color of the activity bar is showing. Regarding the alignment of the badge, what I wanted to show is that the text “3” is misaligned. In this screenshot taken with the smartphone, the misalignment is more visible.

[jschr]

Thanks, I see the issue in iOS safari. I've opened a new issue: #286