-
Notifications
You must be signed in to change notification settings - Fork 231
2D image array with mipmap levels causes validation error #1388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Interesting, I've noticed there is an active PR #955 and seems it fixes the problem. With that changes there are no issues with 2d arrays images with mipmaps |
@Mikalai have you created a github project that I could check out to test this issue? Copying and pasting code and making up my CMake files might work, but also could introduce differences. FYI, I've done several code reviews of #PR955 but the changes are intrusive enough that I've taken a step back and got on with other pending work. Essentially I'll need to go through all the changes in this PR and really check that it's doing things in a appropriate way, and whether there are simpler less intrusive ways to implement them. This all takes time so has to compete with the long list other tasks I have on my plate. |
@robertosfield I've added it as a test to the vsgExamples fork https://github.com/Mikalai/vsgExamples/tree/2d_image_array_issue/tests/vsgterrain. If needed I can create a separate repo. |
I have create a PR to merge this with vsgExample, I'd merge it as a 2d_image_array_issue branch like yours. If this example would help others, beyond this current testing/debugging task, would you be happy publishing as open source? |
No problem to publish it from my side, but it is actually a port of this example with minor changes in shaders https://github.com/SaschaWillems/Vulkan/blob/master/examples/terraintessellation/terraintessellation.cpp. And probably to complete it to be an example it also requires replacing frustum class with something that already exists in vsg and some clean up is needed. |
Describe the bug
Hello, I've faced next behavior when switched from ktx file without mipmap level to ktx with pregenerated mipmap levels. There is an error when using 2D image array with mipmaps levels loaded from ktx file. There is no issue if similar image but without mipmap levels is used. Though maybe I've misconfigured something.
To Reproduce
There is a code sample. Attempt to do the same with VSG as here https://github.com/SaschaWillems/Vulkan/blob/master/examples/terraintessellation/terraintessellation.cpp
This is what I got
Attaching three files heightmap.ktx with elevation information, numbers.ktx 7 layers with mipmaps, numbers-nomipmap.ktx same 7 layers but without mipmaps.
heightmap.zip
numbers.zip
numbers-nomipmap.zip
Sample program accepts arguments --heightmap and --layers
When mipmaps are not used all works fine:
vsgterrain.exe --layers numbers-nomipmap.ktx --heightmap heightmap.ktx --debug
If mipmaps are used program is not working and a lot of errors are printed into console
vsgterrain.exe --layers numbers.ktx --heightmap heightmap.ktx --debug
Expected behavior
Usage of 2D image arrays with mipmaps do not generate errors and program do not hang
Desktop (please complete the following information):
Vulkan Instance Version: 1.3.261
GPU0:
VkPhysicalDeviceProperties:
Appreciate any help
The text was updated successfully, but these errors were encountered: