Add -Wsign-conversion -Wsign-promo compiler flags (#43)

* Add `-Wsign-conversion -Wsign-promo` compiler flags

* chore: Update to Visual Studio 22 to match GitHub windows-latest image

Co-authored-by: David Sze <[email protected]>

Author: dsze

.github/workflows/windows.yml

@@ -11,7 +11,7 @@ jobs:
           choco install cmake
       - name: build
         run: |
-          cmake -S . -B build -G "Visual Studio 16 2019" -A x64
+          cmake -S . -B build -G "Visual Studio 17 2022" -A x64
           cmake --build build --target ALL_BUILD --config Release
       - name: test
         run: |

CMakeLists.txt

@@ -70,7 +70,7 @@ if(ENABLE_TESTS)
   if(WIN32)
     target_compile_options(testStatsdClient PRIVATE -W4 -WX /external:W0)
   else()
-    target_compile_options(testStatsdClient PRIVATE -Wall -Wextra -pedantic -Werror)
+    target_compile_options(testStatsdClient PRIVATE -Wall -Wextra -pedantic -Werror -Wsign-conversion -Wsign-promo)
   endif()
   target_include_directories(testStatsdClient PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/tests)
   target_link_libraries(testStatsdClient ${PROJECT_NAME})

include/cpp-statsd-client/StatsdClient.hpp

@@ -66,7 +66,7 @@ class StatsdClient {
                  const std::string& prefix,
                  const uint64_t batchsize = 0,
                  const uint64_t sendInterval = 1000,
-                 const unsigned int gaugePrecision = 4) noexcept;
+                 const int gaugePrecision = 4) noexcept;
 
     StatsdClient(const StatsdClient&) = delete;
     StatsdClient& operator=(const StatsdClient&) = delete;
@@ -82,7 +82,7 @@ class StatsdClient {
                    const std::string& prefix,
                    const uint64_t batchsize = 0,
                    const uint64_t sendInterval = 1000,
-                   const unsigned int gaugePrecision = 4) noexcept;
+                   const int gaugePrecision = 4) noexcept;
 
     //! Returns the error message as an std::string
     const std::string& errorMessage() const noexcept;
@@ -158,7 +158,7 @@ class StatsdClient {
     mutable std::string m_buffer;
 
     //! Fixed floating point precision of gauges
-    unsigned int m_gaugePrecision;
+    int m_gaugePrecision;
 };
 
 namespace detail {
@@ -182,7 +182,7 @@ inline StatsdClient::StatsdClient(const std::string& host,
                                   const std::string& prefix,
                                   const uint64_t batchsize,
                                   const uint64_t sendInterval,
-                                  const unsigned int gaugePrecision) noexcept
+                                  const int gaugePrecision) noexcept
     : m_prefix(detail::sanitizePrefix(prefix)),
       m_sender(new UDPSender{host, port, batchsize, sendInterval}),
       m_gaugePrecision(gaugePrecision) {
@@ -197,7 +197,7 @@ inline void StatsdClient::setConfig(const std::string& host,
                                     const std::string& prefix,
                                     const uint64_t batchsize,
                                     const uint64_t sendInterval,
-                                    const unsigned int gaugePrecision) noexcept {
+                                    const int gaugePrecision) noexcept {
     m_prefix = detail::sanitizePrefix(prefix);
     m_sender.reset(new UDPSender(host, port, batchsize, sendInterval));
     m_gaugePrecision = gaugePrecision;

include/cpp-statsd-client/UDPSender.hpp

@@ -320,8 +320,8 @@ inline void UDPSender::sendToDaemon(const std::string& message) noexcept {
                             (struct sockaddr*)&m_server,
                             sizeof(m_server));
     if (ret == -1) {
-        m_errorMessage = "sendto server failed: host=" + m_host + ":" + std::to_string(m_port) +
-                         ", err=" + std::to_string(SOCKET_ERRNO);
+        m_errorMessage = "sendto server failed: host=" + m_host + ":" +
+                         std::to_string(static_cast<unsigned int>(m_port)) + ", err=" + std::to_string(SOCKET_ERRNO);
     }
 }
 

tests/StatsdServer.hpp

@@ -59,7 +59,11 @@ class StatsdServer {
         // Try to receive (this is blocking)
         std::string buffer(256, '\0');
         int string_len;
+#ifdef _WIN32
         if ((string_len = recv(m_socket, &buffer[0], static_cast<int>(buffer.size()), 0)) < 1) {
+#else
+        if ((string_len = recv(m_socket, &buffer[0], buffer.size(), 0)) < 1) {
+#endif
             m_errorMessage = "Could not recv on the socket file descriptor";
             return "";
         }