Skip to content

Commit ab3db34

Browse files
author
MacroFake
committed
Merge bitcoin/bitcoin#25713: tidy: run clang-tidy in quiet mode
3fe58a9 tidy: run clang-tidy in quiet mode (fanquake) Pull request description: This should cut the amount of output by atleast half. ```bash /opt/homebrew/opt/llvm/bin/clang-tidy --use-color -p=bitcoin bitcoin/src/wallet/test/fuzz/coinselection.cpp 278 warnings generated. Suppressed 278 warnings (278 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. ``` becomes ```bash /opt/homebrew/opt/llvm/bin/clang-tidy --use-color -p=/bitcoin -quiet bitcoin/src/wallet/test/fuzz/coinselection.cpp 278 warnings generated. ``` See https://clang.llvm.org/extra/clang-tidy/. > --quiet > Run clang-tidy in quiet mode. This suppresses > printing statistics about ignored warnings and > warnings treated as errors if the respective > options are specified. However the `run-clang-tidy` option is `-quiet`. See https://github.com/llvm/llvm-project/blob/f28c006a5895fc0e329fe15fead81e37457cb1d1/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py#L244. ACKs for top commit: jamesob: ACK bitcoin/bitcoin@3fe58a9 Tree-SHA512: 936cfab09a78e71a4a2a2b3539087c1a95fe279923cc8c3f950c70924d6920dcd54b0da8b5493a1337c23a3b25834ab0db5a6b0c660c6e46d750f0fc966e7625
2 parents 5871b5b + 3fe58a9 commit ab3db34

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

ci/test/06_script_b.sh

+2-1
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,9 @@ if [ "$RUN_FUNCTIONAL_TESTS" = "true" ]; then
3535
fi
3636

3737
if [ "${RUN_TIDY}" = "true" ]; then
38+
set -eo pipefail
3839
export P_CI_DIR="${BASE_BUILD_DIR}/bitcoin-$HOST/src/"
39-
CI_EXEC run-clang-tidy "${MAKEJOBS}"
40+
( CI_EXEC run-clang-tidy -quiet "${MAKEJOBS}" ) | grep -C5 "error"
4041
export P_CI_DIR="${BASE_BUILD_DIR}/bitcoin-$HOST/"
4142
CI_EXEC "python3 ${DIR_IWYU}/include-what-you-use/iwyu_tool.py"\
4243
" src/compat"\

0 commit comments

Comments
 (0)